search

vfarcic / crossplane-tutorial

42 stars 276 forks source link

ControllerConfig outdated #2

Open dvgitit opened 5 months ago

dvgitit commented 5 months ago

replace with current implementation

krin-wang commented 5 months ago

@dvgitit could u pls explain a bit more? Is this related to https://github.com/vfarcic/crossplane-tutorial/issues/3? thx.

dvgitit commented 5 months ago

@dvgitit could u pls explain a bit more? Is this related to https://github.com/vfarcic/crossplane-tutorial/issues/3? thx.

It is more or less just a note that DeploymentRuntimeConfig replaces Controller config. Nevertheless, this example repo is very good.

ControllerConfig is the CRD type for a packaged controller configuration. Deprecated: This API is replaced by DeploymentRuntimeConfig, and is scheduled to be removed in a future release. See the design doc for more details: https://github.com/crossplane/crossplane/blob/11bbe13ea3604928cc4e24e8d0d18f3f5f7e847c/design/one-pager-package-runtime-config.md

Source: https://doc.crds.dev/github.com/crossplane/crossplane/pkg.crossplane.io/ControllerConfig/v1alpha1

vfarcic commented 5 months ago

@krin-wang Those are not related. DeploymentRuntimeConfig replaces ControllerConfig. It's a better (more flexible) way to define config for a provider which I did not use so far mostly to avoid potential compatibility issues with older Crossplane. For now, both are working and will continue working for a while. I will, eventually, rewrite manifests to use DeploymentRuntimeConfig but, for now, that should not be a problem.