search

vfarcic / docker-flow-cron

MIT License
24 stars 9 forks source link

service scaling & serviceName support #16

Closed d-h1 closed 7 years ago

d-h1 commented 7 years ago

had some issues with the unit tests, hopefully you can review it and tell me what needs to be fixed.

vfarcic commented 7 years ago

I can go through the PR this weekend. Please let me know if that's OK.

d-h1 commented 7 years ago

sure, thanks!

d-h1 commented 7 years ago

I agree that the service shouldn't run the job on creation, but I still believe the service should be created making it visible (with docker service ls) that we have a scheduled job for later.

Also I've started the feature with df-swarm-listener support, where the service will create it's own scheduling, making it difficult to delay service creation.

How about we solve this by creating the service with 0 replicas? That way the service gets created immedietely but doesnt run the job until it's scheduled time?

vfarcic commented 7 years ago

I never tried creating a service with 0 replicas. If that works, it's a great solution. Go for it :)

d-h1 commented 7 years ago

I checked by running docker service ps <service-name> after service creation, it shows nothing until the scheduled job actually runs, also docker service ls shows 0/0 until cron rescales it to 1.

I've pushed the fix!

vfarcic commented 7 years ago

Merged!

Would you like to own this project? I will not be able to dedicate time to it for at least three months. If you'd like to own it, I can get you up-to-speed with what's missing.

d-h1 commented 7 years ago

Thanks @vfarcic!

Sure, that sounds great!

d-h1 commented 7 years ago

I'm currently working on swarm-listener support and then I plan to add docs so other people can start using it :)

vfarcic commented 7 years ago

That's great. I see that you're already on top of it.

I just gave you the access to the repo so that you can push directly to it. I have a cluster for hosting all DFP docs (e.g. proxy.dockerflow.com, monitor.dockerflow.com, etc). Once you think docs are ready, I'll add cron.dockerflow.com. I'll just need stack.yml from this repo with the docs. It should be similar to the docs service in https://github.com/vfarcic/docker-flow-proxy/blob/master/stack.yml.

Also, I'll do some marketing among Docker Captains, my blog, conferences, and so on :)

vfarcic commented 7 years ago

Sorry for not getting back to you earlier. I'm having trouble getting on top of all my pending tasks.

I went quickly through the PR and it looks good. Great work!