search

vfr / UXReader-iOS

UXReader PDF Framework for iOS
Other
290 stars 66 forks source link

Bitcode support #5

Open Studiosus opened 7 years ago

Studiosus commented 7 years ago

Hey! Many thanks for the project, it's great! Wanted to ask is it possible to add bitcode support?

vfr commented 7 years ago

Bitcode support is possible - one just needs to build PDFium with the right compiler flags and set the framework bitcode build option. I'll put together instructions for building PDFium from source for iOS shortly so you can do this.

Neogene commented 6 years ago

Thank you, +1 for tut on PDFium compiling, or please compile a bitcode enabled build.

muhammad-zohaib-ehsan commented 6 years ago

@vfr Any update on the instructions you mentioned above.It will be very helpful. Thanks

paulocoutinhox commented 6 years ago

Hi,

I made a repository with instructions to build it. It is working very well. But i need solve some problems related here:

https://github.com/prsolucoes/mobile-pdfium/issues/1

Thanks in any help.

juliand665 commented 6 years ago

Sorry to bug you, @vfr, but you seem to be the only person on the internet that knows how to compile PDFium for iOS correctly. It would be incredibly helpful if you could write out how exactly you managed to compile the binary.

paulocoutinhox commented 4 years ago

Hi,

It is working. If anyone wanna, it is building on travis and all instructions is here: https://github.com/prsolucoes/mobile-pdfium

Thanks.

paulocoutinhox commented 4 years ago

Hi,

I make a project to build pdfium master branch for iOS.

It is working fine for arm, arm64 and macos.

There is only one problem on ios simulator (os=ios and cpu=x64).

I post the issue on project here: https://github.com/prsolucoes/mobile-pdfium/issues/5

Can anyone help me solve this pls.

Thanks.

muyexi commented 4 years ago

@prsolucoes I tried the prebuilt binary with bitcode enabled, got this error:

Undefined symbols for architecture arm64:
  "_FPDFDest_GetPageIndex", referenced from:
      -[UXReaderDocument actionForDest:] in UXReaderDocument.o
      -[UXReaderDocumentPage actionForLink:] in UXReaderDocumentPage.o
ld: symbol(s) not found for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

Any idea what's wrong?

paulocoutinhox commented 3 years ago

Hi,

You can get all here: https://github.com/paulo-coutinho/pdfium-lib

Thanks.

wonderffee commented 3 years ago

@prsolucoes I tried the prebuilt binary with bitcode enabled, got this error:

Undefined symbols for architecture arm64:
  "_FPDFDest_GetPageIndex", referenced from:
      -[UXReaderDocument actionForDest:] in UXReaderDocument.o
      -[UXReaderDocumentPage actionForLink:] in UXReaderDocumentPage.o
ld: symbol(s) not found for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

Any idea what's wrong?

use FPDFDest_GetDestPageIndex instead of FPDFDest_GetPageIndex from: https://github.com/pvginkel/PdfiumViewer/pull/173

muyexi commented 2 years ago

@paulocoutinhox Can you enable Bitcode support for this repo? I just had a try but to no avail.