search

vfremaux / moodle-mod_flashcard

A mpdule providing a memoizong helper activity using Leitner model
5 stars 10 forks source link

Update to new version causes error #17

Closed germanvaleroelizondo closed 5 years ago

germanvaleroelizondo commented 5 years ago

When upgrading to the new versiontoday, I got the following error:

Warning: require_once(/Warning: require_once(/var/www/html/lib/eventslib.php): failed to open stream: No such file or directory in /var/www/html/mod/flashcard/lib.php on line 29): failed to open stream: No such file or directory in /var/www/html/mod/flashcard/lib.php on line 29

I can not create a new empty lib\eventslib.php file today. I can not comment out line 29 in lib.php.

I will need to ask the IT guys at my University tomorrow.

Paul Powell wrote on 8 January 2019, 04:31 "Installed this for 3.6 today and it causes a nasty whitescreen for the whole site. This is due to /lib/eventslib.php being required by lib.php. Commenting out this line (29 in lib.php) gets it working. Furthermore, another (less serious) error is caused by line 170 of renderer.php. This stops the user overview from being displayed. $OUTPUT->pix_icon needs changing to $this->output->pix_icon."

vfremaux commented 5 years ago

Hi German, what branch are you using ?

Valery

Le dim. 17 févr. 2019 à 18:01, Germán Valero notifications@github.com a écrit :

When upgrading to the new versiontoday, I got the following error:

Warning: require_once(/Warning: require_once(/var/www/html/lib/eventslib.php): failed to open stream: No such file or directory in /var/www/html/mod/flashcard/lib.php on line 29): failed to open stream: No such file or directory in /var/www/html/mod/flashcard/lib.php on line 29

I can not create a new empty lib\eventslib.php file today. I will need to ask the IT guys at my University.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/vfremaux/moodle-mod_flashcard/issues/17, or mute the thread https://github.com/notifications/unsubscribe-auth/ABrId_UwFU0eAvsjR2E0bZzkUAD1hiaLks5vOYrdgaJpZM4a_qgM .

germanvaleroelizondo commented 5 years ago

Modflashcard 3.5.0 (Build 2019011000) 2018120600 in a server with Moodle 3.6.2+ (Build: 20190118) PHP Version 7.2.14

germanvaleroelizondo commented 5 years ago

Hi Valery,

The IT guy at my University commented out the line described and the server works again.

But I fear many more Moodlers might suffer from the same problem.

vfremaux commented 5 years ago

Hi german

this is indeed a version incompatibiity : lib/eventslib.php has disappeared in moodle 3.6 so the only match for flashcard over 3.6.1 is the MOODLE_36_STABLE branch

Cheers Valery

Le lun. 18 févr. 2019 à 15:37, Germán Valero notifications@github.com a écrit :

Modflashcard 3.5.0 (Build 2019011000) 2018120600 in a server with Moodle 3.6.2+ (Build: 20190118)

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/vfremaux/moodle-mod_flashcard/issues/17#issuecomment-464753833, or mute the thread https://github.com/notifications/unsubscribe-auth/ABrIdwBhqZ09vFKiXxrjEtQXeWbczYEkks5vOrqhgaJpZM4a_qgM .

germanvaleroelizondo commented 5 years ago

Hi Valery, The current problem can be easily reproduced:

A new empty local Moodle 3.6.2+ (Build: 20190208) server, PHP Version 7.1.10

When I install from the Moodle plugins database, choosig the version for Moodle 3.6, it causes a white screen freeze.

install flashcard from moodle plugins database for m36

And the plugin does have the culprit line:

require_once($CFG->libdir.'/eventslib.php');

vfremaux commented 5 years ago

hi German

I renewed the 3.6 zip in moodle.org. Something in my production process seems going wrong when a new master branch is being handled and the last branch zip seems NOT reflecting the reference code.

This is fixed for flashcard, at least synced to dev stable version.

cheers Valery

Le mar. 19 févr. 2019 à 17:18, Germán Valero notifications@github.com a écrit :

Hi Valery, The current problem is: A new empty Moodle 3.6 server, when I install from the Moodle plugins database, choosig the version for Moodle 3.6, it causes a white screen freeze.

[image: install flashcard from moodle plugins database for m36] https://user-images.githubusercontent.com/2671923/53030003-a4881600-342f-11e9-87b3-70d10a6cb482.png

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/vfremaux/moodle-mod_flashcard/issues/17#issuecomment-465200377, or mute the thread https://github.com/notifications/unsubscribe-auth/ABrId9Nz_GWEovuXjsnnWG3aLFKiF4G5ks5vPCPGgaJpZM4a_qgM .

germanvaleroelizondo commented 5 years ago

Hi Valery,

Do you know when will the Moodle plugins database have the right versions ?

vfremaux commented 5 years ago

I have dropped the zip yesterday.

Cheers Valery

Le mar. 19 févr. 2019 à 17:31, Germán Valero notifications@github.com a écrit :

Hi Valery,

Do you know when will the Moodle plugins database have the right versions ?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/vfremaux/moodle-mod_flashcard/issues/17#issuecomment-465206722, or mute the thread https://github.com/notifications/unsubscribe-auth/ABrId9LyP9O6CItS8EiNf_3okx3QQvl6ks5vPCbhgaJpZM4a_qgM .

germanvaleroelizondo commented 5 years ago

I installed from Moodle plugins database,

but I got $plugin->version = 2019011000; // The current module version (Date: YYYYMMDDXX):

Warning: require_once(C:\Temp\m_3_6_2_plus\server\moodle/lib/eventslib.php): failed to open stream: No such file or directory in C:\Temp\m_3_6_2_plus\server\moodle\mod\flashcard\lib.php on line 29

Fatal error: require_once(): Failed opening required 'C:\Temp\m_3_6_2_plus\server\moodle/lib/eventslib.php' (include_path='C:\Temp\m_3_6_2_plus\server\moodle/lib/pear;C:\Temp\m_3_6_2_plus\server\php\PEAR') in C:\Temp\m_3_6_2_plus\server\moodle\mod\flashcard\lib.php on line 29

BUT, if instead of installing from the Moodle plugins database, I download the ZIP file for Moodle 3.6, it will download the correct file 3.6.0 (Build 2019011000)

THE PROBLEM seems to be that the Moodle plugins database page in https://moodle.org/plugins/mod_flashcard shows automatically Release 3.5.0 (Build 2019011000)

and if i try to install now from there 3.6.0 (Build 2019011000) (2019011000)Moodle 3.6, choosing my 3.6 server, it will automatically WRONGFULLY attempt to install this 3,5 version:

[OK] Nombre del plugin que será instalado [flashcard]

[OK] Versión del plugin [2019011000] [OK] Versión de Moodle requerida [2018042700] [OK] Nombre completo del componente [mod_flashcard] [OK] Nivel de madurez declarado [MATURITY_STABLE]

[OK] Lote del plugin [3.5.0 (Build 2019011000)] [Depuración (debug)] Se encontró archivo de idioma [flashcard] [OK] Revisión de acceso de escritura [C:\Temp\m_3_6_2_plus\server\moodle/mod]

Validación exitosa, la instalación puede continuar

AND it will freeze my server.

germanvaleroelizondo commented 5 years ago

SO, the problem is that the Moodle plugins database by default will offer the 3.5 version only for 3.5.

It should instead offer a version for all supported Moodle branches. See https://moodle.org/plugins/atto_cloze

bad versions offered

good versions offered

vfremaux commented 5 years ago

Actually i don't know what provoques the difference in exposing the plugin..

as all the versions are updated in the "Versions" panel

my guess is that the front panel of the plugin exposure only presents the most recent update, and the versions attached to it. So if you update the 3.5 branch with a bugfiwed package, it seems this version will come up to the front download proposal.

I don't think i can do lot for that...

Cheers Valery

Le sam. 23 févr. 2019 à 21:34, Germán Valero notifications@github.com a écrit :

SO, the problem is that the Moodle plugins database by default will offer the 3.5 version only for 3.5.

It should instead offer a version for all supported Moodle branches. See https://moodle.org/plugins/atto_cloze

[image: bad versions offered] https://user-images.githubusercontent.com/2671923/53291396-2782d680-3778-11e9-94db-6d64e57680f8.png

[image: good versions offered] https://user-images.githubusercontent.com/2671923/53291398-2ce02100-3778-11e9-9f44-991c020481cc.png

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/vfremaux/moodle-mod_flashcard/issues/17#issuecomment-466691095, or mute the thread https://github.com/notifications/unsubscribe-auth/ABrId8uZ_-wu4SugzFYWibWHkA1_qRGXks5vQaXugaJpZM4a_qgM .

vfremaux commented 5 years ago

I think you need explicitely get the 36 branch version to avoid this. did you ?

Valery

Le sam. 23 févr. 2019 à 21:09, Germán Valero notifications@github.com a écrit :

I installed from Moodle plugins database,

but I got $plugin->version = 2019011000; // The current module version (Date: YYYYMMDDXX):

Warning: require_once(C:\Temp\m_3_6_2_plus\server\moodle/lib/eventslib.php): failed to open stream: No such file or directory in C:\Temp\m_3_6_2_plus\server\moodle\mod\flashcard\lib.php on line 29

Fatal error: require_once(): Failed opening required 'C:\Temp\m_3_6_2_plus\server\moodle/lib/eventslib.php' (include_path='C:\Temp\m_3_6_2_plus\server\moodle/lib/pear;C:\Temp\m_3_6_2_plus\server\php\PEAR') in C:\Temp\m_3_6_2_plus\server\moodle\mod\flashcard\lib.php on line 29

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/vfremaux/moodle-mod_flashcard/issues/17#issuecomment-466688088, or mute the thread https://github.com/notifications/unsubscribe-auth/ABrId9hig1uN3yPjHvXAk3sI-TnBsyoCks5vQaAVgaJpZM4a_qgM .

germanvaleroelizondo commented 5 years ago

I did choose the 3.6 version.

I just saw the exact same wrong behaviour seen in your Flashcards set (https://moodle.org/plugins/mod_flashcard)

with the new trema theme (https://moodle.org/plugins/theme_trema)

And google analytics (https://moodle.org/plugins/pluginversions.php?plugin=local_ganalytics)

Restriction by cohort (https://moodle.org/plugins/availability_cohort)

Knowledge sharing (https://moodle.org/plugins/block_knowledge_sharing)

User bulk enrolment (https://moodle.org/plugins/pluginversions.php?plugin=local_bulkenrol)

Course completed ewnrolment (https://moodle.org/plugins/pluginversions.php?plugin=enrol_coursecompleted)

Microsoft onedrive document converter (https://moodle.org/plugins/pluginversions.php?plugin=fileconverter_onedrive)

The foundation theme (https://moodle.org/plugins/theme_foundation)

The last two plugins do not show ANY Moodle branch supported, even though they do have a 3.6 compatible version.

With some of these plugins, when I try to install it from the Moodle plugins database in my 3.6.2 server, it downloads the 3.5 version instead.

Maybe we should contact David Mudrak, as this issue now affects several plugins ?

vfremaux commented 5 years ago

i think you can indeed, if u are using the embedded plugin manager tools. This might be a mispreparation of the moodle side plugins API. This could be fine it be reporter indeed. Cheers Valery

Le sam. 2 mars 2019 à 15:48, Germán Valero notifications@github.com a écrit :

I did choose the 3.6 version.

I just saw the exact same wrong behabiour with the new trema theme at https://moodle.org/plugins/theme_trema.

When I try to install from the Moodle plugins database in my 3.6.2 server, it downloads the 3.5 version.

Maybe we should contact David Mudrak, as this issue now affects several plugins ?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/vfremaux/moodle-mod_flashcard/issues/17#issuecomment-468926936, or mute the thread https://github.com/notifications/unsubscribe-auth/ABrIdxJqimhu4QgfUpCzmylrPigcBTsbks5vSo8_gaJpZM4a_qgM .

germanvaleroelizondo commented 5 years ago

I just posted on the Moodle developer forum at https://moodle.org/mod/forum/discuss.php?d=383331.

germanvaleroelizondo commented 5 years ago

I have finally figured it out. Silly old me :( Problem solved, issue closed.

See https://moodle.org/mod/forum/discuss.php?d=383331#p1550506