MAE-2205 - Fixed for syntax of Oracle-specific concat() function

Great Logan

Actually i do not manage any test plan under Oracle. I will by the way integrate changes and exploit receip in a larger review in my 80 plugins.... ;-)

In case other change trick should appear, i will be glad to handle them also in a focussed code review to gain efficiency ....

thanks ! Valery

Le 09/05/2016 19:42, logan-reynolds a écrit :

Hello,

This is Logan Reynolds with Remote-Learner, and I've been working with George Chen on the revised fixes to the M27 version of mod_flashcard. George has confirmed the problem appears to be resolved with your latest branch https://github.com/vfremaux/moodle-mod_flashcard/tree/MOODLE_27_STABLE , however I'm submitting this one change to comply with Oracle's concat() function format, just to ensure compatibility across all supported RDBMs. Please feel free to contact if you have any questions, and thank you for your contributions :)

Regards, Logan Reynolds
    You can view, comment on, or merge this pull request online at:
https://github.com/vfremaux/moodle-mod_flashcard/pull/7
    Commit Summary
MAE-2205 - Fixed for syntax of Oracle-specific concat() function
File Changes
M locallib.php https://github.com/vfremaux/moodle-mod_flashcard/pull/7/files#diff-0 (2)
Patch Links:
https://github.com/vfremaux/moodle-mod_flashcard/pull/7.patch

https://github.com/vfremaux/moodle-mod_flashcard/pull/7.diff
— You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub https://github.com/vfremaux/moodle-mod_flashcard/pull/7

vfremaux / moodle-mod_flashcard

MAE-2205 - Fixed for syntax of Oracle-specific concat() function #7