Android 13 support

[vfsfitvnm]

Will do once google releases the android 13 aosp system image for emulators

• [x] #262
• [ ] #265
• [x] #266

[BluePixel4k]

So in my Android Studio I can already download the image of the API 33 and start it as an emulator 😃:

[vfsfitvnm]

Yes you can, but it's the one with google play services in it. For your interest, google provides the pure aosp images with a certain delay (they are considered less important somehow).

[BluePixel4k]

Ok I understand, thanks for your explanation.

[BluePixel4k]

I tried out the latest debug apk (65 - Link) and there the bug #266 seems to be gone. And the bug #265 is a lot better. Compered to the latest official release 0.4.2, the notification layout looks a bit different and tidy.

Did you change anything fundamental, since the last release version?

[vfsfitvnm]

I think it is due to this. This is a win-win solution honestly - I don't have to deal with the nonsense changes A13 introduced.

However I'm still looking forward to fix the notification cover mismatch.

[BluePixel4k]

Sounds good, can you please publish a new release version for the meantime, so that the app can be used better under A13 again?

Maybe you can dare to make the A13 changes again, if the function #131 became impertinent, then I think it wouldn't look so empty anymore.

[BluePixel4k]

We were happy too early. With the new version v0.4.3 the two bugs (#266 & #265) have not improved for me.

I have now cloned the app into my Work profile and there the bug #266 no longer occurs. Then I grabbed another debug apk (63 - Link) and there the bug #266 is also gone. It seems that there is a problem with the database and it is not the API version 33?!

Possibly it is because I have been with ViMusic since almost the first version? Have there been any fundamental changes to the database since launch?

BTW: With the new installation, the problem #59 seems to be gone for me. Up to now it still occurred.

[BluePixel4k]

Very strange behavior... I have now opened the app from the Work profile again, after a long break, and now the two bugs, with the notification, are present there too.... 😕

[vfsfitvnm]

It just finished building the aosp system image. Ok.

266: The debug version worked because of the option System > Appearance > Show song cover, which is enabled by default. Without that option, the thumbnail is low res (somehow). You release version has that option disabled.

265: Reproduced

[vfsfitvnm]

265 Looks like a bug: https://issuetracker.google.com/issues/243778594

[vfsfitvnm]

However, how is your notification responsiveness? Mine is pathetic - i.e. I press any button (play, skip or whatever) and the notification gets updated after 5 seconds. Not sure if it's a emulator/system image thing (I hope so)

[vfsfitvnm]

Note to self: sometimes the PlayerService has some sort of crash in A13 when destroyed - in fact the process is re-started afterwards (it should not). Other than wasting resources, this will cause the "persistent queue" to not work

[BluePixel4k]

It just finished building the aosp system image.

Awesome 🚀

https://github.com/vfsfitvnm/ViMusic/issues/266: The debug version worked because of the option System > Appearance > Show song cover, which is enabled by default. Without that option, the thumbnail is low res (somehow). You release version has that option disabled.

Thx, good to know.

https://github.com/vfsfitvnm/ViMusic/issues/265 Looks like a bug: https://issuetracker.google.com/issues/243778594

Strange, i don't have that bug with Spotify.

However, how is your notification responsiveness? Mine is pathetic - i.e. I press any button (play, skip or whatever) and the notification gets updated after 5 seconds. Not sure if it's a emulator/system image thing (I hope so)

For me, the speed is fine. I also think this is an emulator problem.

https://user-images.githubusercontent.com/77979781/187751808-ce86d783-b92a-481e-9c10-67989515188c.mp4

[vfsfitvnm]

Would you make a screen record of spotify's notification (when you skip the next song)?

[BluePixel4k]

Would you make a screen record of spotify's notification (when you skip the next song)?

https://user-images.githubusercontent.com/77979781/188261447-27078ebc-c146-4c3a-9aec-55b8f356b5d4.mp4

265 Looks like a bug: https://issuetracker.google.com/issues/243778594

Strange, i don't have that bug with Spotify.

Now I noticed that sometimes, after a restart of the app, the first song also displays a wrong cover in Spotify. From the next song on, however, the bug disappears.

[vfsfitvnm]

Ok, I think it's time to target A13. The bug in https://issuetracker.google.com/issues/243778594 has been fixed, however I will still apply a workaround for A13 devices. Also, to avoid duplicates such as #470, the "Show song cover" will be enabled by default on A13

[vfsfitvnm]

This is how it looks like with the workaround (it may rarely display the previous cover and the text always refresh now...)

https://user-images.githubusercontent.com/46219656/196741026-ef89be9d-dfa1-4f0f-a54b-aa97b28deb77.mp4

[vfsfitvnm]

Unfortunately it still occurs sometimes, but it's not consistent though.

[BluePixel4k]

Thx you for the improvement! Its working a lot better then before. 👍🏼

Unfortunately it still occurs sometimes, but it's not consistent though.

Thats true. For me the bug occur most commonly at the startup of the app -> no notification picture displayed.

[vfsfitvnm]

Thats true. For me the bug occur most commonly at the startup of the app -> no notification picture displayed.

Does it still occur to you?! :/

[BluePixel4k]

Yes sadly, but not very often. Currently I'm fine with it. :)

[vfsfitvnm]

Damn :/ The first song is always displayed fine in the emulator

[BluePixel4k]

Hmm thats strange. 😕