search

vfx-rs / ptex-bind

High-level cxx-based bindings for Ptex https://github.com/wdas/ptex https://crates.io/crates/ptex https://crates.io/crates/ptex-sys
https://crates.io/crates/ptex
Apache License 2.0
5 stars 2 forks source link

Funky values continued #8

Closed ratmice closed 7 months ago

ratmice commented 7 months ago

This adds some (failing) tests for the EdgeId enum. It doesn't appear as though the ptex c++ library currently catches these funky values as it does for the MeshType and DataType tests previously added.

My assumption is it might be worthwhile looking into fixing these upstream, if it is a safe assumtion that writing isn't really a hot path where the additional checks could be problematic? Since this appears to need more work, i've currently set them into draft mode.

While doing this I noticed some renaming/clippy stuff on the previously added tests.

ratmice commented 7 months ago

So, I believe this leaves to be done BorderMode, EdgeFilterMode, and MetaDataType. I didn't see any mechanisms for setting those from the existing sys crate.

I think those should be left to subsequent patches which implement setBorderMode, setEdgeFilterMode and writeMeta on PtexWriter.