Closed kjbranch closed 4 months ago
If you're referring to helpers like h_canIBJ
, I think they should probably all be deleted. I could see some minimal use in keeping them, but I mostly just didnt delete them yet, because I thought it would make this PR too difficult to review.
Added item requirements to tech that had artificial morph variants. This should improve clarity and reduce the likelihood of future errors, and became possible after #1507.
canIBJ
,canJumpIntoIBJ
, etc. toh_canIBJ
or{"tech": "canIBJ"}
, etc.Morph
to tech and used{"tech": "canIBJ"}
, etc. in the artificial morph helpers, and simplified the regular helpers.This is only part of adding all items to their tech, but this is likely the majority of it. In a future PR, all helpers, such as
h_canIBJ
can be removed andcanIBJ
used instead.The only error found was escaping Beta PBs with a springball bomb jump which didn't include a bomb, as well as 7 instances of
canResetFallSpeed
that didn't requireMorph
. These 7 still need to be verified and are all included in the final commitAdd morph to canResetFallSpeed
.