vg-json-data / sm-json-data

JSON representations of Super Metroid Game Data
Other
26 stars 12 forks source link

Add Items to Tech Pt.1 - Artificial Morph #1511

Closed kjbranch closed 4 months ago

kjbranch commented 4 months ago

Added item requirements to tech that had artificial morph variants. This should improve clarity and reduce the likelihood of future errors, and became possible after #1507.

This is only part of adding all items to their tech, but this is likely the majority of it. In a future PR, all helpers, such as h_canIBJ can be removed and canIBJ used instead.

The only error found was escaping Beta PBs with a springball bomb jump which didn't include a bomb, as well as 7 instances of canResetFallSpeed that didn't require Morph. These 7 still need to be verified and are all included in the final commit Add morph to canResetFallSpeed.

kjbranch commented 4 months ago

If you're referring to helpers like h_canIBJ, I think they should probably all be deleted. I could see some minimal use in keeping them, but I mostly just didnt delete them yet, because I thought it would make this PR too difficult to review.