vg-mjg / mjg-repo

it's the maajan repo files in all its glory
https://repo.riichi.moe
MIT License
16 stars 17 forks source link

Library fix #82

Closed watterle closed 3 years ago

watterle commented 3 years ago

Low priority, but it would be nice for the Library page to be easier to maintain. 2000 lines of code in the same file are a bit too much

Furitenman commented 3 years ago

That might be an organization thing. Maybe we could break down the Library in different sub-pages?

sharmayu commented 3 years ago

Just be autistic enough ... or you can do it the same way you did the updates with separate json files, that works.

Maybe we could break down the Library in different sub-pages?

The current tabs organization works, separating them in subpages feels wonky.

Furitenman commented 3 years ago

Just be autistic enough

Guess I'll do that. Gimme a couple of days to figure something out.

Furitenman commented 3 years ago

Okay, so this is the solution I came up with. I divided the entire library in different html files, which are loaded into the library. This would have the following structure:

├───resources
│       resources-game.html
│       resources-gguides.html
│       resources-majplus.html
│       resources-media.html
│       resources-mjg.html
│       resources-mleague.html
│       resources-offline.html
│       resources-strategy.html
│       resources-toolz.html

Tell me what you guys think and I'll push it to master.

sharmayu commented 3 years ago

We won't know until we actually see it in action, so push and we'll feel if it's good or not.

watterle commented 3 years ago

looks good tbh

Furitenman commented 3 years ago

It's up. Test it and tell me what you guys think.

watterle commented 3 years ago

Really nice. The only problem is that if you open the page coming from the light theme, you get a wierd mix of light and dark themes 882

Furitenman commented 3 years ago

Yeah, good catch. Should be fix in the next push.

watterle commented 3 years ago

nice