I think this could be improved a little bit. First of all, while you may not need the lines outputted by Chrome/Chromium, these messages could be hinting what is happening if something went wrong during the execution of Chromium headless. To be able to disable them when everything is working properly would be nice, but they should probably be enabled by default.
To make it short, here is what is missing:
We need to be able to toggle on/off the browser's output, probably by adding a new attribute to the ChromeHeadless class
Docstrings and comments may be updated accordingly
Documentation may also be updated to mention the possibility to turn on/off the browser's output
The commit message should be describing the changes rather than the issue you had
Hello, thank you for opening a pull request.
I think this could be improved a little bit. First of all, while you may not need the lines outputted by Chrome/Chromium, these messages could be hinting what is happening if something went wrong during the execution of Chromium headless. To be able to disable them when everything is working properly would be nice, but they should probably be enabled by default.
To make it short, here is what is missing:
On a side note, I would probably use
instead of relying on a file object returned by open.
If you're willing to do the changes yourself, feel free to do so. If not, no problem, I (or someone else, we never know) will take care of it.
I will also open an issue related to this, feel free to discuss possible changes here when it will be opened.