vgarvardt / gue

Golang queue on top of PostgreSQL
MIT License
261 stars 24 forks source link

Trying to install 4.1.0 fails due to otel deps #287

Open agis opened 4 days ago

agis commented 4 days ago

Apparently otel removed some of their previously-working import paths (https://github.com/open-telemetry/opentelemetry-go/issues/2897), so we might need to bump their versions in the v4 branch.

$ go get -u github.com/vgarvardt/gue/v4
go: github.com/vgarvardt/gue/v4 imports
    go.opentelemetry.io/otel/metric/instrument: cannot find module providing package go.opentelemetry.io/otel/metric/instrument
go: github.com/vgarvardt/gue/v4 imports
    go.opentelemetry.io/otel/metric/instrument/syncint64: cannot find module providing package go.opentelemetry.io/otel/metric/instrument/syncint64
go: github.com/vgarvardt/gue/v4 imports
    go.opentelemetry.io/otel/metric/unit: cannot find module providing package go.opentelemetry.io/otel/metric/unit
vgarvardt commented 4 days ago

Starting from v1.25.0 OTel requires go 1.21 and gue is currently pinned to go 1.20. I'll bump min required version to 1.21 since 1.20 reached end of support already.

vgarvardt commented 4 days ago

pls check if https://github.com/vgarvardt/gue/releases/tag/v5.7.0 solves your problem

PS GH closed the issue automatically after the linked PR was merged

agis commented 4 days ago

Can you backport this to v4 so that I can give it a try? Thanks!

On Thu, Jul 4, 2024, 18:47 Vladimir Garvardt @.***> wrote:

pls check if https://github.com/vgarvardt/gue/releases/tag/v5.7.0 solves your problem

— Reply to this email directly, view it on GitHub https://github.com/vgarvardt/gue/issues/287#issuecomment-2209264508, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGJ6WGAWYMNOHSH2K6C6VTZKVVANAVCNFSM6AAAAABKLVQLUWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMBZGI3DINJQHA . You are receiving this because you authored the thread.Message ID: @.***>

vgarvardt commented 4 days ago

oh, v4 - this version is not support anymore, most likely you'd need to create your fork

agis commented 3 days ago

Would you be open to a PR backporting this in v4, so that we avoid forking?

vgarvardt commented 3 days ago

I do not even have a separate branch with v4, will try to create one later today from the commit before switched to v5

agis commented 3 days ago

Thanks a lot!