search

vgmrips / vgmplay-legacy

VGM file command-line player and Winamp plugin.
http://vgmrips.net
224 stars 54 forks source link

Disable or Reimplement PortTalk features #10

Open felipesanches opened 9 years ago

felipesanches commented 9 years ago

Commit 705d7d0201cfa04eab1ada60d690d9bf0a82edb3 removed PortTalk-related source files. The files were removed because their copyright holder explicitely states in the header of these files that their distribution is forbidden. Thus, our usage and distribution of those files could potentially be understood as copyright infringiment.

As a side effect, the removal of those headers seem to have broken the build for Windows. I haven't tested the windows build, but I can predict it is broken based on the usage of these functions in VGMPlay.c:

unsigned char OpenPortTalk(void); void ClosePortTalk(void);

In order to fix the issue, we may consider eighter removing the feature or reimplementing the functionality provided by the concerning PortTalk source files.

djtuBIG-MaliceX commented 6 years ago

Remind me to address this by actually raising a PR to replace this for use with inpout32.dll.