birdybro
commented
3 years ago After many attempts with getting zlib in there, I have no idea how to get this to work in MSVC2019, so I'm going the MSYS2 method, but it still fails in MSYS2:
$ make WINDOWS=1
...
VGMPlay.c:43:10: fatal error: conio.h: No such file or directory
43 | #include <conio.h> // for _inp()
| ^~~~~~~~~
compilation terminated.
make: *** [Makefile:297: obj/VGMPlay.o] Error 1Apparently conio.h is missing. So I commented out the 3 lines in the master referencing conio.h to see what happens... then I get a zlib.h missing error.
VGMPlay.c:85:10: fatal error: zlib.h: No such file or directory
85 | #include <zlib.h>
| ^~~~~~~~
compilation terminated.
make: *** [Makefile:297: obj/VGMPlay.o] Error 1Which doesn't make sense since it is actually there, it's just in ~/VGMPlay/zlib, however... in_vgm.c, VGMPlay_AddFmts.c, and VGMPlay.c all have zlib.h included with #include <zlib.h> which is for implementation dependent method of searching for the header. Changing it to #include "zlib/zlib.h" yields the following:
Compiling VGMPlay.c ...
VGMPlay.c: In function ‘GetGZFileLengthW’:
VGMPlay.c:1276:10: warning: implicit declaration of function ‘_wfopen’; did you mean ‘_lopen’? [-Wimplicit-function-declaration]
1276 | hFile = _wfopen(FileName, L"rb");
| ^~~~~~~
| _lopen
VGMPlay.c:1276:8: warning: assignment to ‘FILE *’ {aka ‘struct __sFILE64 *’} from ‘int’ makes pointer from integer without a cast [-Wint-conversion]
1276 | hFile = _wfopen(FileName, L"rb");
| ^
Compiling VGMPlay_AddFmts.c ...
Compiling Stream.c ...
Compiling ChipMapper.c ...
Compiling VGMPlayUI.c ...
VGMPlayUI.c: In function ‘main’:
VGMPlayUI.c:560:5: warning: implicit declaration of function ‘_getch’; did you mean ‘_getc_r’? [-Wimplicit-function-declaration]
560 | _getch();
| ^~~~~~
| _getc_r
VGMPlayUI.c:611:11: warning: implicit declaration of function ‘_kbhit’ [-Wimplicit-function-declaration]
611 | while(_kbhit())
| ^~~~~~
VGMPlayUI.c: In function ‘wprintc’:
VGMPlayUI.c:1941:12: warning: implicit declaration of function ‘_vsnwprintf’; did you mean ‘vswprintf’? [-Wimplicit-function-declaration]
1941 | RetVal = _vsnwprintf(printbuf, BufSize - 0x01, format, arg_list);
| ^~~~~~~~~~~
| vswprintf
Compiling mmkeys_Win.c ...
Compiling dbus_stub.c ...
Linking vgmplay ...
/usr/lib/gcc/x86_64-pc-msys/9.3.0/../../../../x86_64-pc-msys/bin/ld: cannot find -lz
collect2: error: ld returned 1 exit status
make: *** [Makefile:274: vgmplay] Error 1So is there also a prerequisite that is not being mentioned for MSYS2?
ValleyBell
superctr
Summary
The current build instructions do not list a key prerequisite and this causes current MSVC versions to fail compiling later builds. Given that there have been no new releases since 2018 and significant changes have happened since then, the readme ought to be updated to reflect this common difficulty many will have (since I doubt most people are using MSVC 6.0 in 2020, the software is not free and the installation process on Windows 10 is a nightmare --> https://www.codeproject.com/Articles/1191047/Install-Visual-Studio-on-Windows).
Errors/attempts
Version used: latest commit as of today --> https://github.com/vgmrips/vgmplay/commit/ead5e589d2aa9fbf5bc470eb9ab8795ef455440e
I tried both methods that were provided to me by the readme as is. Upon opening it says the 2010 build tools cannot be located. I did two tests, running it without upgrading the build tools configuration, and running it with upgrading the build tools configuration (as the prompt from MSVC2019 told me I should). Each time I unzipped a fresh folder to be sure that it was a fresh run. Here's the logs from each:
Just running "build solution" after loading the vcprojx file as instructed like normal:
With the build being upgraded as prompted by MSVC2019:
So the first error indicated I need to upgrade the project to be able to build it. So I did that next time, and the errors I got showed 2 linker errors (LNK2019 - https://docs.microsoft.com/en-us/cpp/error-messages/tool-errors/linker-tools-error-lnk2019?f1url=%3FappId%3DDev16IDEF1%26l%3DEN-US%26k%3Dk(LNK2019)%26rd%3Dtrue&view=msvc-160) and 2 unresolved externals (LNK1120 - https://docs.microsoft.com/en-us/cpp/error-messages/tool-errors/linker-tools-error-lnk1120?f1url=%3FappId%3DDev16IDEF1%26l%3DEN-US%26k%3Dk(LNK1120)%26rd%3Dtrue&view=msvc-160).
I have all of the MS VC redistributals from the chocolatey vcredist-all package which should cover all those bases. I'm now downloading and installing the Win7 SDK (https://www.microsoft.com/en-us/download/details.aspx?id=8279) just to cover my bases... and I got the same errors. Looking through the issues yields this identical problem to mine:
https://github.com/vgmrips/vgmplay/issues/44
The compilation instructions do not list zlib as a prerequisite, or any prerequisites, which can unnecessarily lead to confusion.
I'll now attempt to, as those instructions point out, compile zlib on windows 10 for use in MSVC2019 to see if I can get anywhere. If I do, I'll report back.