vgmrips / vgmplay-legacy

VGM file command-line player and Winamp plugin.
http://vgmrips.net
221 stars 52 forks source link

Rewrite relative-path string concat code. #82

Closed eloj closed 3 years ago

eloj commented 3 years ago

Rewrite this code segment to use snprintf() instead of strncpy(), and post-check for string truncation instead of pre-checking for overflow.

This fixes "warning: 'strncat' specified bound depends on the length of the source argument [-Wstringop-overflow=]"

eloj commented 3 years ago

Never mind I guess, didn't realize this repository is no longer actively supported.

ValleyBell commented 3 years ago

Yeah, I'm accepting and merging PRs and that's it.

VGMPlay v0.50 still doesn't have all features of v0.40, so the repo is not archived yet. But I'm not working on this iteration anymore.