Closed mikelow closed 1 month ago
Ok. I thought that might be the right place for path for the libs, but wasn't sure. By "keep it as-is" do you mean ditch the PR or move forward with it? I'm cool with either.
@mikelow I think the BASS libraries should be in a separate vgmtrans subdirectory inside of /usr/lib (to prevent conflicts with any version of system BASS)
This requires a rpath to be set though 🐸
By "keep it as-is" do you mean ditch the PR or move forward with it? I'm cool with either.
I did some research and it seems like the place for this stuff is indeed /opt
, we should avoid putting our deps into system lib directories imo
I didn't understand how our linux packaging worked when I started on this, and now I'm no longer convinced that fixing the install command is adding much value. I'll close the PR.
This is an attempt to improve the Linux installation. Linux convention isn't my forte, so hopefully I didn't mess this up.
The changes:
${CMAKE_INSTALL_PREFIX}/share/vgmtrans
(ie. /usr/local/share/vgmtrans).${CMAKE_INSTALL_PREFIX}/lib
(ie. /usr/local/lib)How Has This Been Tested?
Loaded mame_roms.xml successfully on Ubuntu 22.04, Windows 10, and MacOS Sonoma. libbass loaded successfully on Ubuntu.
Types of changes
Checklist: