This renames every UpperCamelCase method in vgmtranscore, including format files. There may be some functions I missed if they're contained only in a cpp file and not declared in a header. In some instances, I gave methods more descriptive name: GetTrackPointers() is changed to parseTrackPointers(), the GetByte(), GetWord(), etc methods, are now readByte(), readWord(), etc.
There are also a few classes where I renamed fields and methods, such as LogItem and RiffFile.
One change I probably should have made separately is updating the pitchBendRange related events and methods to use only a cents parameter instead of both a semitones and cents parameter.
The commit is added to .git-blame-ignore-revs. Hopefully the hash remains the same after pushing to master.
How Has This Been Tested?
Tested that playback is still working.
Tested that the changes to RIFF did not affect DLS or SF2 output.
Types of changes
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[x] Cleanup
Checklist:
[x] My code follows the code style of this project.
sykhro
commented
2 weeks ago
This renames every UpperCamelCase method in vgmtranscore, including format files. There may be some functions I missed if they're contained only in a cpp file and not declared in a header. In some instances, I gave methods more descriptive name:
GetTrackPointers()is changed toparseTrackPointers(), theGetByte(),GetWord(), etc methods, are nowreadByte(),readWord(), etc.There are also a few classes where I renamed fields and methods, such as LogItem and RiffFile.
One change I probably should have made separately is updating the pitchBendRange related events and methods to use only a
centsparameter instead of both asemitonesandcentsparameter.The commit is added to .git-blame-ignore-revs. Hopefully the hash remains the same after pushing to master.
How Has This Been Tested?
Tested that playback is still working. Tested that the changes to RIFF did not affect DLS or SF2 output.
Types of changes
Checklist: