search

vgsatorras / egnn

MIT License
420 stars 75 forks source link

In place operation in `coord_model()` of `egnn_clean.py` #3

Closed Olimoyo closed 2 years ago

Olimoyo commented 2 years ago

Thanks for sharing the code for this paper!

I ran into some autograd issues with the following in place operation:

https://github.com/vgsatorras/egnn/blob/dcd37610639d3e2d9836c3931756d706b3b2d47f/models/egnn_clean/egnn_clean.py#L81

Is this a bug or was it done intentionally for some other reason?

vgsatorras commented 2 years ago

Hi,

Thank you for letting us know. This in-place operation does not seem to create problems in the provided experiments. Did you run into these issues when using the model in a different project? Was it fixed by writing "coord = coord + agg" instead?

In any case, I have just modified that line to "coord = coord + agg" to avoid future in-place operation issues.

Best, Victor

Olimoyo commented 2 years ago

It was with a different project and "coord = coord + agg" fixed it.