vgstation-coders / vgstation13

Butts
GNU Affero General Public License v3.0
265 stars 544 forks source link

Can't delete specific designs from research servers and consoles. #11478

Open D3athrow-Issues opened 8 years ago

D3athrow-Issues commented 8 years ago

(WEB REPORT BY: kavlax REMOTE: 172.93.109.202:7777)

Revision 4d935af35fa01c86e8925136514deebb4f59b34d

General description of the issue Deleting designs from the research server, then resetting a research console will not remove that design from the console.

What you expected to happen Design unprintable.

What actually happened Can still print the damn thing.

Steps to reproduce if possible Try deleting only, say, the AI upload and robotics control circuits from the research server, then reset the console in R&D.

FudgePucker commented 8 years ago

Still might be worth it. You need access to relink with server, you don't need access for protolathe.

Hell you could make a public protolathe with the more dangerous items removed.

Exxion commented 8 years ago

I think you completely and entirely misunderstood the issue here

ComicIronic commented 8 years ago

This is likely due to behaviour that causes fabricators to only add items to their designs, to stop starting designs for the mech fab from being wiped on sync. Still need to find a good solution for that system.

FudgePucker commented 8 years ago

Also allowing designs to be permanently removed might be a bad idea, someone can law two ai to remove research designs. So some assface can disable R&D and force them to start from ground zero.

ComicIronic commented 8 years ago

But that's intentional, it's why you're told to back your shit up onto disks. Any half-decent RD will make a disk backup of all their levels, it takes 2 minutes.

PJB3005 commented 8 years ago

I know the good solution:

We tear fabricator code out, take it behind the shed into the sekrit repo, shoot it with a minigun, then rewrite it from scratch.

ComicIronic commented 8 years ago

There is literally nothing wrong with the fab code that I refactored.

We could try making the mapped servers start with the Robotics designs and then have designs wiped on sync, that would be relatively easy.

PJB3005 commented 8 years ago

There is literally nothing wrong with the fab code that I refactored.

Should we tell him?

ComicIronic commented 8 years ago

literally nothing wrong

gbasood commented 8 years ago

(not)shitcode aside we still need to rip out R&D as a whole