vgstation-coders / vgstation13

Butts
GNU Affero General Public License v3.0
265 stars 545 forks source link

Tiny hermit crabs hidding themselves in their helmet shells #12968

Closed jknpj closed 6 years ago

jknpj commented 7 years ago

Description of issue

undercover https://webmshare.com/QYn0J

smol mommi sprites are able to hide their red rogue eyes under big hats/hemets

Difference between expected and actual behavior

Expected: A RED-EYED MOMMI AI CALL IT Actual: AHELP WTF MOMMI JUST KILLED ME FOR NO RAISINS

Steps to reproduce

As any "tiny" type of crab, grab any big hat/helmet and use the verb "Hide"

Length of time in which bug has been known to occur

God know, at least a few months

Issue bingo

Please check whatever applies. More checkboxes checked increase your chances of not being yelled at by every contributor.

Probe1 commented 7 years ago

Yes, and there are MANY other helmets that murderous mommis chose for that purpose. Whether it's a good idea to allow this is worth talking.

It's not truly a bug, and it's only kind of an oversight if you fudge the meaning of oversight. It's more like no one cared.

jknpj commented 7 years ago

Since this got a Discussion tag, what about keeping this as a feature but only if not-emaged?

Probe1 commented 7 years ago

I mean ideally you'd just make their eyes glow through anything in the hat slot if the eyes are red.

9600bauds commented 7 years ago

Borg eyes already work like that for no fucking reason, we just have to figure out how they work

Probe1 commented 7 years ago

hahaha holy shit we're doomed

ghost commented 7 years ago

Alright so I know why borg eyes and MoMMI eyes work like that and I too know why MoMMI eyes don't show up as red in that screenshot

kol1th commented 7 years ago

The borg eyes show up above every single thing, even lighting, which is retarded. This sounds like a feature to me

ghost commented 7 years ago
Celt: If you hide, your red eyes are on the floar plane
Celt: if you don't
Celt: your red eyes poke out of a hat
Celt: because they're on the lighting layer
Probe1: um
Probe1: how even
Celt: Hm?
Probe1: how would you handle this
Probe1: i guess
Probe1: if emagged
Celt: Super easily
Celt: if(emagged)
Celt: shit I could tell you how to make that PR
Celt: one moment
Celt: the issue is
Celt: uh
Celt: if the MoMMI was under a table hiding
Celt: their red eyes would show through it
Probe1: yes
Probe1: exactly.
Probe1: that's why I wrote how would you handle this
Probe1: it basically ruins them hiding
Celt: Hm
Celt: got it
Celt: Have it layer above the hat if they're hiding but not above anything else
Probe1: post it in the issue so everyone knows

@kol1th The reason it layers above darkness is obvious - it's illuminated

Ephx1 commented 7 years ago

Borg lights shut off if resting or their actuators are shot

kol1th commented 7 years ago

@DrCelt they also appear above chairs

Kitfox88 commented 7 years ago

hacked mommis are so evil their piercing gaze cannot be hidden from

jknpj commented 7 years ago

Evil is in the eye of the beholder

ihadtoregisterforthis commented 7 years ago

Some MoMMI sprites have an emagged variant that changes the color of the chassis. These small ones could have one but that would mean having to sprite.