search

vgstation-coders / vgstation13

Butts
GNU Affero General Public License v3.0
265 stars 546 forks source link

stange anti-british bug #13158

Closed D3athrow-Issues closed 5 years ago

D3athrow-Issues commented 7 years ago

(WEB REPORT BY: pvak REMOTE: 172.93.109.202:7777)

Revision (Should be above if you're viewing this from ingame!)

General description of the issue writing a message with the pound sign (£) breaks it and makes it unable to be sent (for chat + ooc) when used on ahelp it makes the bwoink sound but its invisible for the receiver http://puu.sh/t4Tug/b79ebe81a3.png

What you expected to happen be able to use £

What actually happened racism against british people

Steps to reproduce if possible write £ on chat try send message get nothing

i blame ira for this

Exxion commented 7 years ago

All special characters break it Blame BYOND

mph55 commented 7 years ago

You could remove the double url_encode in browserOutput.dm so issues like those and the Hécate are fixed, it's not like UTF-8 is used outside of the screaming russians

Exxion commented 7 years ago

Goonchat ALWAYS uses UTF-8 The problem is that BYOND doesn't.

PJB3005 commented 7 years ago

@mph55 is correct here.

That'd fix it, but only for the Windows-1252 range.

PJB3005 commented 7 years ago

No the issue is that anything above 127 is different between UTF-8 and Windows-1252, so the Javascript client side throws a Unicode Decode Error.

I would've already fixed this if Javascript weren't a shit language and actually allowed you to specify the encoding to use when decoding.

PJB3005 commented 7 years ago

Like, my best idea would be to catch the UnicodeDecodeError and then use a regex to turn the encoded Windows-1252 bytes that aren't valid UTF-8 into UTF-8.

ghost commented 7 years ago

Why fix this, the Brits deserve it

Wizardcrying commented 7 years ago

@DrCelt stop shitposting.

IratePirate commented 7 years ago

You people make me sick.

ReindH commented 7 years ago

Of course there are no british, it's the future!

Shadowmech88 commented 5 years ago

This no longer seems to be the case. image

DamianX commented 5 years ago

But did you try it with 2 clients? Sounds like the issue is when they use two different encodings.

PJB3005 commented 5 years ago

Nah. This is fixed.

Exxion commented 5 years ago

This was the exact issue libvg was originally created to fix