vgstation-coders / vgstation13

Butts
GNU General Public License v3.0
260 stars 541 forks source link

Weird message appearing in chat, then multiple people unable to move #14696

Open Blithering opened 7 years ago

Blithering commented 7 years ago

corners A message which appeared to be a snippet of conversation appeared in chat as if it were an admin narration, immediately following which several people lost the ability to move. they could still be pushed around by others, so they weren't somehow anchored.

Blithering commented 7 years ago

@clusterfack No instance of those words appear in the logs before ahelps about it, did notice [18:38:53]DEBUG: Runtime in <b>action.dm</b>, line <b>53</b>: <b>Cannot modify null.moved.</b> <a href='?_src_=holder;viewruntime=[0x21098d27]'>[view]</a> just before the first people started talking about being stuck.

SonixApache commented 7 years ago

It happened a while ago too, @PJB3005 was there. A debug message in a light related file, I think.

unid15 commented 7 years ago

Spooky 💀

PJB3005 commented 7 years ago

Yes, I forgot to remove the debug messages when me and MSO were trying to figure out why the fuck the shuttles were having broken lighting while porting StonedMC.

The messages should only happen when SSlighting sleeps during its processing, which causes the master controller to break and makes SSlighting "forget" its current processing queue. There's no sleeps though.

I suspect that somehow, BYOND's CPU counter internally breaks, so it begins inserting random sleep calls into loops which causes SSlighting to explode. The movement issue is another symptom as I suspect BYOND fails to handle input and ticks smoothly anymore.

I've personally tried to fix it when this happened and the CPU counter got stuck at around ~65536, and it persisted through would restarts indicating that the entire process broke and needed a restart. Couldn't manage to crash it though and we just nagged pomf.

PJB3005 commented 7 years ago

code/controllers/subsystem/lighting.dm#L72 for the message.

Blithering commented 7 years ago

@PJB3005 Is there an open issue for that? If so, I'll close this one as a duplicate.

PJB3005 commented 7 years ago

@Blithering AFAIK no.