vgstation-coders / vgstation13

Butts
GNU Affero General Public License v3.0
266 stars 546 forks source link

Allow traders to be targeted by antags #15835

Closed Durgen closed 5 years ago

Durgen commented 7 years ago

People have been requesting this for more than a year, but as far as I can tell no one has opened an issue about it. Traders being unable to be targeted by antags is a relic from a time before the trade shuttle existed and should be reverted.

https://github.com/vgstation-coders/vgstation13/pull/9514

Now almost all traders eventually make their way to station, besides those who die doing something stupid in space. Restricting them from being targets no longer make sense.

Dusk-a commented 7 years ago

I will defend many things for traders but I agree that never being an antag target is kind of dumb. No reason they can be antag yet can't be a target themselves ever.

Kammerjunk commented 7 years ago

Good for discussion if people keep bringing this up Remember than they were made immune because of complaints from antags, not complaints from traders. They were angery because there wasn't really a good chance for, say, the chef to get his greentext if they're on an entirely different station

Orangerush commented 7 years ago

@Kammerjunk any way for only certain jobs that could reasonably go out and get them get them as a target or is that impossible currently?

Kammerjunk commented 7 years ago

Ahahaha

Kammerjunk commented 7 years ago

Well, I mean, maybe? I wouldn't mess with it because I didn't like what I was looking at the last time I was looking at antag stuff, but maybe? It sounds like it'd be really snowflakey code though

Orangerush commented 7 years ago

i anger

So what you're saying is ANTAG DATUMS?

Durgen commented 7 years ago

@Orangerush Traders don't need a restriction, they are far easier to kill than for example Miners or Xenoarchs. just do this 'hey secborg go kill that bird in arrivals he stole 1 credit from me'

Kammerjunk commented 7 years ago

If they go to the station at the same time you look for them, certainly

Dusk-a commented 7 years ago

Its not too difficult for a borg to get on their outposts either provided they know where it is. They can even use the trade ship's console to move it

Kurfursten commented 7 years ago

This restriction was made at a time when Traders could not access PDAs. Today most Traders will save up the 100 credits for a PDA, meaning you can pinpoint them. Time for trader targets again. 👍

Besides, this change will make some of the most obnoxious voices be quiet for a while.

Kammerjunk commented 7 years ago

Yeah, until the traitors start complaining and asking for the thing they don't have yet again ¯\(ツ)

SonixApache commented 7 years ago

needing objectives to kill shitbirds

ghost commented 7 years ago

An antag is more than their greentext. If you want to antagonize the shit out of traders, go fuck them up. You don't need to send newfags off to accomplish nothing in regards to the action in the round because they're too dumb to look beyond their obj's when the guys who want to fuck up traders can just use their antag tickie to go KFC the place already.

Kammerjunk commented 7 years ago

I had thought that'd be brought up at some point, but it works both ways.

ghost commented 7 years ago

For the people who have a hardon for greentext instead of not giving a shit it marginally reduces the chance of at least something happening on the station before they sit in a locker for the shuttle. Yes, xenoarch/miners exist and no, adding more to that off-station list isn't helping.

Kurfursten commented 5 years ago

antagonistes no longer target