search

vgstation-coders / vgstation13

Butts
GNU Affero General Public License v3.0
265 stars 546 forks source link

Staff of Necromancy fires Staff of Change bolts when placed in a turret #16125

Open SonixApache opened 7 years ago

SonixApache commented 7 years ago

Description of issue

The Staff of Necromancy fires Staff of Change bolts when placed in a turret.

Difference between expected and actual behavior

turret that fires necromancy bolts vs turret that fires change bolts

Steps to reproduce

Build a turret stick a staff of necromancy in it

Specific information for locating

Reason's pretty simple; the staff of necromancy doesn't actually use a projectile to do its shit far as I can tell. As such, its projectile_type is that of it's parent, which is the staff of change. Parent class is https://github.com/vgstation-coders/vgstation13/blob/ffeb48bf5a520214264841512936098bb0bb01ed/code/modules/projectiles/guns/energy/special.dm#L78

Staff of Necromancy is https://github.com/vgstation-coders/vgstation13/blob/ffeb48bf5a520214264841512936098bb0bb01ed/code/modules/projectiles/guns/energy/special.dm#L149

Exxion commented 7 years ago

Why is it a gun if it doesn't use projectiles? Who did that?

SonixApache commented 7 years ago

Me, in #14030. Unforeseen consequences.

Blithering commented 7 years ago

Staff of necromancy wouldn't be very useful as a turret would it? they don't target dead people and the bolt has no effect on the living

SonixApache commented 7 years ago

It'd need special code, yeah. Honestly, turrets could use somewhat of a rework in general.