Taking off jumpsuit inside of suitstorage deletes your ID, belt, and everything in your pockets

[D3athrow-Issues]

(WEB REPORT BY: delightedmerchant REMOTE: 172.93.109.202:7777)

Revision

bd483ea93c1801b5fd45f38f3d5b8c01fa4cc7ad

Description

title

Steps to Reproduce

Take off jumpsuit while inside suit storage

What you Expected

I don't know what I expected.

What Actually Happened

ID, belt, and pockets got deleted.

[Cyadox]

Removing your jumpsuit drops those items onto the floor automatically, and are probably being nullspaced since they can't be put into the suitstorage container.

Is it intended for people to be able to access their inventory while in a suit storage unit? If not, a little sanity would fix this.

[Intigracy]

Actually, it's dropping them into the suit storage unit's contents.

[gbasood]

so basically this just needs to tell the player where the items go i guess

[Exxion]

That and actually let them get them back

[gbasood]

I didn't realize you couldn't dump the storage contents

[MadmanMartian]

Can't you turn off the power and crowbar the stuff out?

[Exxion]

Maybe, but that's a pretty wacky thing to have to do to pull objects out of a unit designed for storing other objects

[Intigracy]

Just make it dump the "loose" contents when opened.

[Cyadox]

Should we even let people drop items while crammed inside what is essentially a suit locker? You can't do that in a normal locker if I recall.

[DamianX]

even if you don't let people do it, some things like robotic arms malfunctioning would have the same effect, might as well provide a way to eject the contents.

[Aurx]

It's safer to assume that people can drop anything anywhere they are than it is to assume nobody will ever add a way to drop things in stupid places.

[Cyadox]

People will always find a way to do stupid things

Fair enough. Intigracy pretty much nailed it, just make it dump anything inside that shouldn't be there.

[gbasood]

Alternatively just make it drop the shit from the suit where you're standing I don't care either way honestly, just that they can get the shit back easier than crowbaring it out without power

[Kurfursten]

It should use get_turf instead of loc. That should be a universal standard.

[MadmanMartian]

man takes off clothes inside closet clothes pop out of the closet

[DamianX]

cigar goes out inside closet butt pops out of the closet

[Aurx]

I can't think off-hand of any circumstances where dropping an item while inside something should intuitively place it outside the thing.
Dropping to turf instead of loc while inside things would, quite reasonably, get bug reported.

[gbasood]

No, it drops inside a suit storage, like the things in EVA. You can't be in those.

[Intigracy]

You can be stuffed into them buddy, it's why you can hack the controls to make them deal more damage.

Simply loop through the contents when it's opened and remove anything not referenced by the three slots. It already does it for mobs.

On Nov 6, 2017 4:27 PM, "sood" notifications@github.com wrote:

No, it drops inside a suit storage, like the things in EVA. You can't be in those.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/vgstation-coders/vgstation13/issues/16472#issuecomment-342334269, or mute the thread https://github.com/notifications/unsubscribe-auth/AD20pGyhhwr64OtvgmvNtzJah_AofYWUks5sz6QGgaJpZM4QTiQd .

[Exxion]

@Kurfursten That is the opposite of true.

[Kurfursten]

@Exxion You can't possibly stand by that claim. If you argue that get_turf should never be used for anything (the opposite), you'd prevent grenades from going off when held in hand because their loc would not be a turf.

[Exxion]

Man, you know what I meant. When one object is dropped by/spawned from/detached from/etc. another, it should always use loc, not get_turf(). get_turf() should be used only very sparingly when moving or spawning objects.

[Kurfursten]

Yes I did

[Aurx]

M8, even if you did take him literally, the negation of "It should use get_turf instead of loc. That should be a universal standard." is not "Never use get_turf".

[Kurfursten]

One verbal tease is enough for me thanks, I don't have the autism necessary to argue with you about the nuances of "negation" versus "opposite".

[Aurx]

"Opposite of true" is false indicates the negation of the statement is true. I'm sorry, I need to confiscate your autist license, you've clearly normalized.

[gbasood]

everyone shut up and fix the bug

[Exxion]

It's really more of an oversight

[SonixApache]

@gbasood you can actually just climb into suit storage units yourself, I usually do it whenever I gotta go AFK as engineer