Windoors don't drop electronics on destruction by melee weapon

Pathid commented 6 years ago

Description of issue

Windoors don't drop electronics on destruction, when destroyed by a melee attack.

Difference between expected and actual behavior

Expected the windoor to create a circuitboard on destruction, yet it doesn't https://github.com/vgstation-coders/vgstation13/blob/c117a35244c04c66ddd2e1b6550777aba416677c/code/game/machinery/doors/windowdoor.dm#L358-L372

Steps to reproduce

Destroy a mapped-in windoor with ~~any weapon~~ scratch that, it has to be with a melee weapon.

Server revision

Game: f82455d2654e74f1a2877fe99384c9da40e5454a Patches: 78ac2f909b50159df885e55ab563750b9b00c5dd

Issue bingo

Please check whatever applies. More checkboxes checked increase your chances of not being yelled at by every contributor.

[x] Issue could be reproduced at least once
[ ] Issue could be reproduced by different players
[x] Issue could be reproduced in multiple rounds
[x] Issue happened in a recent (less than 7 days ago) round
[x] Couldn't find an existing issue about this

Kammerjunk commented 6 years ago

Every destroyed windoor here is mapped in except the one in the middle of the medbay front hallway. Tested on tgstation, not test_box or something like that. Can't see a merged PR within the last 2 days that addressed this. Which windoor(s) did you destroy? Mapped-in windoors have electronics = null and created windoors have whatever board you made them with. It looks like the board and the accesses on it should get set right. The new circuitboard is moved to loc either way.