search

vgstation-coders / vgstation13

Butts
GNU Affero General Public License v3.0
266 stars 544 forks source link

No warning for ghosting as mmi #17468

Open D3athrow-Issues opened 6 years ago

D3athrow-Issues commented 6 years ago

(WEB REPORT BY: kahnn1 REMOTE: 172.93.109.202:7777)

Revision

1768cfa5bb81ae2bbca5e72fdc190d44de2b9def

Description

No warning for ghosting as an mmi like there is for humans.

Steps to Reproduce

Be mmi, hit ghost.

What you Expected

A warning similar to what happenes when you hit ghost as a human.

What Actually Happened

Hit ghost and insta ghosted and died.

Probe1 commented 6 years ago

Can't reproduce. Tested on live server as of 16-02-18 as well as the test server.

dreamseeker_2018-02-16_14-29-18

Pathid commented 6 years ago

@Probe1 he means as a brain in a man-machine interface.

I think I know why this happens. You were probably in "crit" as the brain mob.

Probe1 commented 6 years ago

Ghosting in an MMI can't be reproduced either

https://i.imgur.com/rdyaOVl.png

Can you explain the crit as a brain mob @Pathid

Pathid commented 6 years ago

You auto-succumb if your health is less than zero. https://github.com/vgstation-coders/vgstation13/blob/2349df3ef207b605a47d2d6b2f1264524ca397bd/code/modules/mob/dead/observer/observer.dm#L307-L327

But the brain doesn't actually die or lose consciousness until health_threshold_dead: -100. https://github.com/vgstation-coders/vgstation13/blob/bd608141b1a8d41ac007e37a3ab003cac103b257/code/modules/mob/living/carbon/brain/life.dm#L129-L140

Probe1 commented 6 years ago

Excellent. Thank you for pointing out the direction to take 😄

Pathid commented 6 years ago

Happy to help.