vgstation-coders / vgstation13

Butts
GNU Affero General Public License v3.0
266 stars 545 forks source link

Central Atmospherics Computer Doesn't Function Correctly #17707

Closed Anglosphere closed 5 years ago

Anglosphere commented 6 years ago

Description of issue

The Central Atmospherics computer does not respond when clicking on individual air alarms, when changing Z levels, or when showing a detailed list.

Difference between expected and actual behavior

When clicking on an individual air alarm, it brings it up, and allows the modification of values in the alarm.

When selecting a new Z level, a new Z level should load with its map.

When clicking on show detail list, a detail list should appear.

Steps to reproduce

Click on the CAC Click on an air alarm Wait 10 minutes Nothing happens

Click on the CAC Click on change Z level Select a Z level Wait 10 minutes Nothing Happens

Click on the CAC Click on Show Detailed List Wait 10 minutes Nothing Happens.

Length of time in which bug has been known to occur

Since https://github.com/vgstation-coders/vgstation13/issues/16654 probably. ahhhhhh

Server revision

Current

Issue bingo

Please check whatever applies. More checkboxes checked increase your chances of not being yelled at by every contributor.

DamianX commented 6 years ago

closing #16654 in favor of this, as this has more information

ghost commented 6 years ago

Thirding it. Borked.

Inorien commented 6 years ago

I think the problem lies in #16395, specifically changes to code/WorkInProgress/Mini/atmos_control.dm I'll give it a good look in a couple of days

BenjaminMichael commented 6 years ago

This is a game balance crippling bug why not revert back before the change was merged? That's what we used to do when stuff broke...