We have three (3) systems for firing events

vgstation-coders / vgstation13

Butts

GNU Affero General Public License v3.0

265 stars 544 forks source link

We have three (3) systems for firing events #18475

Open DamianX opened 6 years ago

DamianX commented 6 years ago

They seem to all do the same thing with varying degrees of awfulness, let's get rid of two them.

https://github.com/vgstation-coders/vgstation13/blob/770d57364ea3d2075bde8ad8dab6202debb0ebdb/code/_hooks/events.dm https://github.com/vgstation-coders/vgstation13/blob/770d57364ea3d2075bde8ad8dab6202debb0ebdb/code/_hooks/hooks.dm https://github.com/vgstation-coders/vgstation13/blob/770d57364ea3d2075bde8ad8dab6202debb0ebdb/code/datums/helper_datums/events.dm

Exxion commented 6 years ago

I don't think the third one is actually used anywhere, but I absolutely could be wrong Also you missed one We have an outdated version of hooks, too

Exxion commented 6 years ago

I was wrong and the third one is used in one place It's troublingly recent though I'm guessing someone was told to use the events system and picked the wrong one

DeityLink commented 3 years ago

lol github

boy2mantwicethefam commented 3 years ago

Rank: Moderator Posts: 1398 Reputation: 411 Stop necroposting, make a new thread. Thread locked.

"No Luke, I am your father" - Darth Vader

DeityLink commented 3 years ago

No such thing as necro posting on github.

Open Issue is Open Issue

boy2mantwicethefam commented 3 years ago

Wait, how would that be called? Necro Open Issue? Necro Issue? Issue That Shouldn't Be? Frankenstein Issue?