vgstation-coders / vgstation13

Butts

GNU General Public License v3.0

264 stars 543 forks source link

Pinpointers don't update to point to malf AIs if the security level is not delta #18927

Closed D3athrow-Issues closed 9 months ago

D3athrow-Issues commented 6 years ago

(WEB REPORT BY: generalveers25 REMOTE: 172.93.109.202:7777)

Revision

62cd864a38abea215454aee8b26cb87b6f85be0e

Description

The pinpointer does not point to Shunted APCs.

Steps to Reproduce

Try to use the pointer to find a shunted milf hiding somewhere so you can go take her out.

What you Expected

To find that hot milf waiting for me

What Actually Happened

The pinpointer pointed to the disk and didn't actually show us the milf.

DamianX commented 6 years ago

At first I thought I broke this when changing from in world to in pinpointer_list but according to this the pinpointers only get their new target if the AI shunts after delta, and I believe they might be able to shunt even before delta. https://github.com/vgstation-coders/vgstation13/blob/62cd864a38abea215454aee8b26cb87b6f85be0e/code/modules/power/apc.dm#L972-L974

Caboozles commented 6 years ago

AI shunted after delta. That shouldn't be it.

DamianX commented 6 years ago

Yeah, that would do it.

Inorien commented 6 years ago

If this is the same round I'm thinking of, there was some fuckery with the disk itself which was suspected to be involved. IIRC there was a shunt and then the disk was destroyed/spaced after (?) such that it respawned, leading to the problem with the pinpointer

nervere commented 9 months ago

Fixed in #34683