search

vgstation-coders / vgstation13

Butts
GNU General Public License v3.0
260 stars 541 forks source link

Zero damage wounds not getting removed when they ought to be #18934

Open Pathid opened 5 years ago

Pathid commented 5 years ago

https://github.com/vgstation-coders/vgstation13/blob/f53783257cbdda5db4c644b8e261715d25b68815/code/modules/organs/organ_external.dm#L597-L601

This looks like it should work on the surface, however...

https://github.com/vgstation-coders/vgstation13/blob/f53783257cbdda5db4c644b8e261715d25b68815/code/modules/organs/organ_external.dm#L362-L371

...this optimization means external organs stop processing, and consequently stop calling update_wounds() after they finish healing. Or at least that's what it looks like. This is apparently why you get tiny bruises sticking around forever.

Exxion commented 5 years ago

This also fucks up bicard healing internal bleeding, since the wound never goes away, so it will just reopen if you run out of bicard