vgstation-coders / vgstation13

Butts
GNU Affero General Public License v3.0
265 stars 543 forks source link

Being cloned and/or getting Staff-of-Change'd makes you lose all your spells #20028

Closed SonixApache closed 5 years ago

SonixApache commented 5 years ago

Description of issue

title i feel like spells are tied to the body rather than the mind for some reason

Difference between expected and actual behavior

be crewman with book magic get turned into a martian | get killed and cloned retain spells vs be crewman with book magic get turned into a martian | get killed and cloned lose all spells

Length of time in which bug has been known to occur

at the latest since role datums, though no specific time

Server revision

d9cb1d08d578e7d63f29e8d681386e438000faf0

Shadowmech88 commented 5 years ago

I asked about this in Discord, and was told that no mobs, including wizards, are intended to keep their spells after cloning. Not sure about staff of change, though.

AI-Is-Rogue commented 5 years ago

18461 for SoC

And I distinctly remember being cloned and keeping my spells a while back after the CMO cloned me and gave me a new identity for some unholy reason.

Exxion commented 5 years ago

@Shadowmech88 But that's wrong, unless it was changed with role datums for some reason. The spells belong to the mind but are used by the body, and so they have to be re-added properly, but aren't always

DamianX commented 5 years ago

No, you were never able to retain your spells after cloning. Spells used to be stored in the body of the wizard. In fact, it was relatively common to headswap their corpses with crewmen to give said crewmen access to spells. That said, I don't know if it was a bug or a feature and I don't care about it being changed either.

Exxion commented 5 years ago

Apparently they used to belong to the mind but that was commented out at some point

strawberrytan commented 5 years ago

I've never actually seen anybody but myself do the wizard magic body hijack but it is fun