Synchronizing research on exosuit fabricators makes them build things instantly

vgstation-coders / vgstation13

Butts

GNU General Public License v3.0

264 stars 541 forks source link

Synchronizing research on exosuit fabricators makes them build things instantly #20621

Open DamianX opened 5 years ago

DamianX commented 5 years ago

Steps to reproduce

Be spessman
Have a R&D console and an exosuit fabricator
Do research (or hit the MAXIMUM RESEARCH button) [this step might not be necessary]
upgrade the components in the fabricator to tier 3
sync the fabricator
try to print something

Difference between expected and actual behavior

It's printed instantly. This is incredibly cool but also completely unintended.

Specific information for locating

probably #20587

MadmanMartian commented 5 years ago

Time mult did end up at 0.17.

Maybe the magic 5 should be reduced?

ShiftyRail commented 5 years ago

Maybe it ends up with a time inferior to a certain threshold which byond considers instant, or so small that it's not noticeable.

DamianX commented 5 years ago

Tech levels shouldn't affect build time, upgraded components should be buffed to compensate change my mind

Pathid commented 5 years ago

Think about it in RTS terms. It's okay for a simple research that costs a bit of time to give something like +15% production speed. Anyway I believe this might be a parenthesis problem:

https://github.com/vgstation-coders/vgstation13/blob/599712325c6ffdd56756618a51f31c19bbf763df/code/modules/research/fabricators.dm#L443

Shouldn't it be diff = round(initial(time_coeff) - (initial(time_coeff)*(T.level+(ptime*5))/25),0.1)

MadmanMartian commented 5 years ago

Yeah. That'll be it

Exxion commented 5 years ago

Those sure do appear to be mathematically equivalent