search

vgstation-coders / vgstation13

Butts
GNU General Public License v3.0
260 stars 541 forks source link

Frankensteins' butchering_drops is always empty #20820

Open DamianX opened 5 years ago

DamianX commented 5 years ago

Description of issue

This is suboptimal because there are certain things like vampire bites that depend on it.

The reason why this is the case is this list here: https://github.com/vgstation-coders/vgstation13/blob/ca74103c629780e1077fb25832ec18837a3fa9fc/code/datums/helper_datums/butchering.dm#L289 It doesn't contain an entry for frankensteins, so no drops are added to the mob. This is technically correct, though, because frankensteins can be made from pieces of any race.

The solution is to refactor the initialization of butchering drops to generate drops based on the species of each body part (so that having a human head would spawn with teeth, but having a grue head would spawn without teeth): https://github.com/vgstation-coders/vgstation13/blob/Bleeding-Edge/code/modules/mob/living/death.dm#L12

unid15 commented 5 years ago

I'm ashamed of the whole butchering drops thing the way it currently is

needs rewrite