search

vgstation-coders / vgstation13

Butts
GNU Affero General Public License v3.0
266 stars 546 forks source link

Lemme talk about some redirect to lobby job bullshit #22219

Closed Killette2 closed 4 years ago

Killette2 commented 5 years ago

Have a job selected to be high, med, or low, doesn't matter Don't get that job and forced to roll assistant Don't get assistant so forced to lobby Hit join My job was available

Jobs infamous for this are scientist and botanist, where botanist will only let you start with 2 but it will let you latejoin to get 3, and scientist lets you start with 3 but will let you latejoin to get 4. What is the point of this bullshit? Why can't I just get the role roundstart if it's open?

Kurfursten commented 5 years ago

I am 90% sure I know the reason this is caused. You sure this is being caused for Scientists on Box? It shouldn't. It makes sense you can't get 3rd botanist because there are only 2 spawn locs and that's what it's searching for. (Mapping issue) Looks like Inti solved it

Intigracy commented 5 years ago

https://github.com/vgstation-coders/vgstation13/blob/578f7e7adb26f4a52cce49f9020b50a7ac6ac80f/code/game/jobs/job/science.dm#L53 https://github.com/vgstation-coders/vgstation13/blob/578f7e7adb26f4a52cce49f9020b50a7ac6ac80f/code/game/jobs/job/science.dm#L54

https://github.com/vgstation-coders/vgstation13/blob/578f7e7adb26f4a52cce49f9020b50a7ac6ac80f/code/game/jobs/job/job.dm#L21 https://github.com/vgstation-coders/vgstation13/blob/578f7e7adb26f4a52cce49f9020b50a7ac6ac80f/code/game/jobs/job/job.dm#L22

with the code as-is this was intentionally done

Killette2 commented 5 years ago

But why? Surely this isn't intentional

Kurfursten commented 4 years ago

Fixed by Inti

SirSkeleto commented 4 years ago

why not just have 'em spawn in the shuttle roundstart so they can roll for antagge