Cancelling worshipping Space Jesus then picking a preset religion causes religion to not load

[D3athrow-Issues]

(WEB REPORT BY: demagoguedimension REMOTE: 206.221.180.138:7777)

Revision

a7ec9c5395391546901dc85d00d4ba1a7d724a62

Description

Namesake

Steps to Reproduce

Prompt yes in first window without changing field, prompt no next window. Then pick "forgotten weapons" and it will default to a non-unique.

What you Expected

To be able to get Murdercube.

What Actually Happened

Got a generic religion with "The Holy Bible" and a pick of book appearance. Note shows as Christianity.

[Demagogue-Dimension]

I suspect that it may be a flag issue. I'm going to look for the right file and see if I can't add a snippet to clear the cache when a religion is not chosen.

EDIT: It seems I was right. It does not seem to overwrite that Christianity is not the chosen religion if you decide to second guess it. Those fields are all still selected when picking a custom and cannot be overwritten. I don't know enough about BYOND code to fix it other than the fact that all of these fields filled when selecting a religion the first time need to clear when the prior menu is returned to.

[Kurfursten]

What is the text of each of the three windows you answered yes, no, and then input text for?

[Demagogue-Dimension]

It's in religions.dm. Lines 18 to 83 at most for the core process.

Regarding what I put in, I pressed yes for the menu asking for the key list as soon as round started by mistake, pressed no when it asked me to be Christian, put in the key forgotten weapons for Murderkube, then it prompted me for which book texture I would like to use. I had copied and pasted the key straight from the religions file. The logs for this occurring are shortly before the submission of this request server time.

It is also possibly a wholly syntax error, since the line for forgotten weapons is missing several spaces. Line 1248.