vgstation-coders / vgstation13

Butts
GNU Affero General Public License v3.0
266 stars 546 forks source link

Foam metal floors have phantom atmosphere #23239

Open D3athrow-Issues opened 5 years ago

D3athrow-Issues commented 5 years ago

(WEB REPORT BY: lazyrobot123 REMOTE: 206.221.180.138:7777)

Revision

795fa3f72078c748f2cccf8cdea3f859d366d662

Description

When using a metal foam grenade to make metal foam floors, they seem to spawn with a breathable atmosphere despite there being no atmosphere there previously.

Steps to Reproduce

Make a metal foam grenade to make metal foam floors (3 parts aluminium, 1 part foaming agent, 1 part poly acid)

Arm the grenade. Toss it into a place of vacuum (In this case, space)

Wait for it to detonate.

Marvel at the air from nowhere.

What you Expected

Considering it can only be made on tiles that have no air, I would expect it to inherit the air from the tile previously.

What Actually Happened

Air from nowhere

Exxion commented 5 years ago

dude turfcode lmao

FudgePucker commented 5 years ago

This would only really be a problem out in the middle of space or REALLY BIG, SHUTTLES ALREADY BEEN CALLED, bombs. The rest of the area has no air from a breach so the air levels would still be too low for breathing and preventing ZAS pushing. Maybe, big maybe, it would be useful to abuse for building a space base.

FudgePucker commented 5 years ago

A welder bomb in a hallway being fixed by a foam grenade for example would have near zero impact from a foam grenade. Five or so turfs have 101 kPa of air, so what? The 20+ turfs have none. Quick math, 5*101/20 is 25, and that's not even a large area.

Exxion commented 5 years ago

To be fair foam necessarily has gas in it, or else it wouldn't be foam To be more fair though it's not exactly likely said gas would just happen to be normal air