vgstation-coders / vgstation13

Butts
GNU Affero General Public License v3.0
266 stars 544 forks source link

Feature Request: Add Radioactive Contamination #23621

Open ghost opened 5 years ago

ghost commented 5 years ago
I'd like to request the addition of radioactive contamination/build up for objects that are exposed to radiation. TG has this feature, and while I know there's a stigma against their code, this seems like a wholly beneficial change by giving players more to do and changing up engineering work a little bit. Right now, radiation never really comes into play unless someone decides to take the shard out for a parade. What this feature would do is essentially keep track of the radiation players/objects are exposed to, and once a certain threshold is passed, turn them into a dangerous source of radiation. Radioactivity would decay over time for people/objects who are no longer exposed to a source, like the shard or singularity, but they would remain dangerous for some amount of time depending on the level of build up. Additionally, to support the new feature, a scanning mode could be added to geiger counters (hold them in hand and click on the object/person you wish to scan) to allow them to detect levels of contamination on a specific object, as well as the ambient radiation they currently detect. This could be used to deadly effect by placing an object near a source of radiation and then bringing it back to the rest of the station, where it will slowly (or potentially rapidly depending on how long it was exposed) kill the person who it is given to/picks it up/stands next to it for too long. Imagine you have an assignment to kill the bartender. So you go to the bar and steal a shaker, place it next to the SM core for a few minutes, then return it to him, saying you found it in the maint tunnels. A few minutes later, he starts coughing up blood, and his hair starts falling out, and he has no idea why. Pros: -Disincentivizes engineer hardsuit rushing (if you're working with the shard itself for extended periods, 75% might not be enough to keep all your stuff rad free). -Makes radiation suits more valuable. -Gives traitor engineers something else to do besides blowing the engines -Gives genetics more to do by fixing the genomic damage done by radiation, and doctors more experience curing radiation in general -!Fun! -Potentially not much work considering the feature is already implemented in tg and their code base is open source (but I'm not much of a coder so I won't say for sure how much work it is to migrate that stuff) Cons: -Potential for griefing via throwing a heavily contaminated object into a high-traffic area. (similar to current shard parades, although less obvious) -Adds some small amount of complexity to engineering tasks by forcing people to use radiation suits in some circumstances.
ghost commented 5 years ago

All fair. I'm not familiar with the way the code works, just the implementation in the game, so I was just kinda spitballing on potential effects.

DrSnips commented 5 years ago

Put a piece(s) of paper next to the [source or radiation like radio transmitter or juke] Leave it there for a bit Scoop them up into a bag or clipboard Put it somewhere Due to the way radiation interacts with people everyone dies instantly by walking next to it

DrSnips commented 5 years ago

Rads are also a medical nightmare because of all of the internal issues it causes and tox damage. 90% of the time you have to clone the person and Id rather have medbay be more than just lmao clone em

ghost commented 5 years ago

Due to the way radiation interacts with people everyone dies instantly by walking next to it

You could have a cap based on object size/whether it fits into a backpack or not. I'm not a nuclear physicist but my guess is a piece of paper won't absorb as much as a larger object, etc.

Rads are also a medical nightmare because of all of the internal issues it causes and tox damage. 90% of the time you have to clone the person and Id rather have medbay be more than just lmao clone em

Maybe that's an issue with the cloners then. I mean, we have organ printers and stuff, but I don't see them used too often. Admittedly I don't spend much time in medbay but it does seem to me that the cloners are used when other options are available just due to ease of use.

DrSnips commented 5 years ago

100 sources of rad is 100 sources of rads. You could load a backpack with 7 cardboard boxes each containing 7 clipboards and each of those containing a max amount of paper. I can think of several other things that you could do something similar with. The issue here isn't the cloner its rads because of how it JUSTs people. They can even make people literally uncloneable.

ghost commented 5 years ago

Yeah. I'm not saying there's no ways to break it, and obviously it requires some amount of refinement, but I still like the general idea. Maybe speaking as someone who doesn't actually know the code that doesn't mean much.

SonixApache commented 5 years ago

wyci

ghost commented 5 years ago

wyci

I'll certainly take a look at the code guides on the wiki. What's involved in porting features from other code bases? I'm sure it's not as simple as a drag and drop, but I can't imagine it's as bad as starting from scratch.

DrSnips commented 5 years ago

You get an idea of how to go about coding it most of the time but a lot of the time you're basicly starting from scratch because if Y needs X to work and X isn't a 1 to 1 transfer you're likely going to redo both. I'm still not for this idea due to how our radiation is.

SonixApache commented 5 years ago

Our radiation code is really not built for nor balanced around getting mariecurie'd to death. The potential for griff and accidental griff is massive.

You'd have to rework all of radiationcode, rework every engine that does anything radiation related, rework all the other sources of radiation (radgun, radstorms, rad meteors, etc), re-design engineering on every map, and rework a bunch of wiki pages -- all while fighting the playerbase who hates major changes.

Interesting concept in theory, ohfuckwhy-tier in practice.

ghost commented 5 years ago

Fair enough. I still like the idea and the execution, if done right, is really great (I'll be honest I think the system TG has for rads is a lot more interesting than what we have) but I get that it not the best fit with the way things are coded now, and I don't have the skills to try and rework and balance the whole system myself. Just a suggestion, maybe something that can be looked at in the future. Thanks for your thoughts.

tuypo1 commented 5 years ago

It sounds cool but potentially way too fucking op Probably best if it can only slightly iradiate objects.

FudgePucker commented 5 years ago

The old spicy chunk of graphite

FudgePucker commented 5 years ago

Also. I am going to give my "I dont like change" reply.

So what am I to do as a MoMMI? Do I have to carefully avoid people until I can get my hands on a geiger counter? Am I to do nothing after spacing an out of control shard? The fuck?

ghost commented 5 years ago

So what am I to do as a MoMMI?

Well presumably the borgs and mommis have built in radiation shielding considering they already take no damage from working with the core. Realistically if they weren't they'd break down since that level of radiation can easily break circuit boards and such, so you could hand wave it as just them being lead plated or whatever else.

tuypo1 commented 5 years ago

If you are a mommi what the fuck are you doing spacing shards Fucking hell we need to be way fucking stricter on the no interference shit.

DrSnips commented 5 years ago

As long as there is no one at the shard there's no reason you can't especially if it's something you set up yourself and fucked up.

FudgePucker commented 5 years ago

I of course would never space a shard over just using the foam.