search

vgstation-coders / vgstation13

Butts
GNU Affero General Public License v3.0
265 stars 544 forks source link

turbine computers can break and need some work* #25548

Open SonixApache opened 4 years ago

SonixApache commented 4 years ago

Description of issue

~~turbine computers, /obj/machinery/computer/turbine_computer, don't work when you link them to a compressor. Clicking the console just straight-up does nothing anymore. It's a shame, because it could be interesting for meme power setups. If I had to guess, it's probably runtiming somewhere in here, maybe because there's no check for pod doors.~~ Update: So when you spawn the compressor first and the turbine second, it breaks the entire thing. So there should probably be error handling for that. Maybe a Topic() for all three parts with a refresh option?

https://github.com/vgstation-coders/vgstation13/blob/cc3296ae6c185c4ae7cef2c9b69b005b996228a8/code/modules/power/turbine.dm#L257-L267

Difference between expected and actual behavior

click console, get data vs click console, get No compatible attached compressor found. OR click console, nothing happens

Steps to reproduce

spawn /obj/machinery/compressor spawn /obj/machinery/power/turbine below it spawn /obj/machinery/computer/turbine_computer near it in the same area wait a bit click console

Length of time in which bug has been known to occur

who fucking knows

Server revision

Game: 40c840911a6a57cf1b4e0921f5cf2a81ec019c08 Patches: 9b0a260ee0e987d97f8e24ef394c89c433b20a23

SonixApache commented 4 years ago

If these aren't ment to work, and aren't ever going to work, we might as well get rid of them.