search

vgstation-coders / vgstation13

Butts
GNU Affero General Public License v3.0
265 stars 543 forks source link

Fat Character breaks Ninja #28690

Open strawberrytan opened 3 years ago

strawberrytan commented 3 years ago

Description of issue

Having a fat character slot roll ninja makes ninja not work as intended - you spawn naked holding a plastic bag with your ninja suit + sword inside of it. You cannot equip the suit and this obviously makes the space jump suicide.

Difference between expected and actual behavior

Ninja approach station via open space, so their suit protects from space vacuum for a limited time. I would expect game to either force me to be thin, provide an emergency diet pill, or more inclusive clothing options for my chosen lifestyle.

Steps to reproduce

Fat character slot > Join as crew > Roll Ninja instead > You are now a fat naked man in the dojo

Specific information for locating

Latest fatninja related fix I think https://github.com/vgstation-coders/vgstation13/pull/27960

Length of time in which bug has been known to occur

Server revision

Blithering commented 3 years ago

This is why we need weeb returned.

Kurfursten commented 3 years ago

Just run laps in the dojo until you are thin

We need a treadmill in there

SonixApache commented 3 years ago

thought that was fixed, guess it re-broke with outfit datums?

Kurfursten commented 3 years ago

It's not actually broken, what the fix did was it gives you the suit in a bag instead of deleting it. You can put it on as soon as you lose weight.

Strawberry is saying it should make you skinny automatically.

SonixApache commented 3 years ago

I thought it was fixed by making ninjas not fat in the first place, what the heck.

Killette3 commented 3 years ago

why not give all off-station antags a 1 unit lipozine pill?

SonixApache commented 3 years ago

the body that is generated for off-station antag roles should just not be fat in the first place

Blithering commented 3 years ago

Does raise the question why we load the player's character for these kinds of roles rather than generating a generic one and plopping a mirror in the room to change up appearance with. Wizards would have less chance of accidentally EMPing their own roboheart as well.

strawberrytan commented 3 years ago

I think if you rolled ninja while observing you'd be fine, like I said I tried to join as a fat crew and got Ninja instead

ghost commented 3 years ago

this should force the crazed weeaboo variant