vgstation-coders / vgstation13

Butts
GNU Affero General Public License v3.0
265 stars 546 forks source link

Couldn't splice phytochemistry. #28931

Open Eneocho opened 3 years ago

Eneocho commented 3 years ago

Description of issue

For a round, I had made healing ambrosia, with phytocarisol, kathalai, tannic acid and opium (also cocaine, mescaline and nutriment). About midround I found a strange seed that had rezadone, peridaxon and thymol (also sugar, phytocarisol and nutriment). I tried to splice the strange seed's phytochemistry to the healing ambrosia I had just made and no dice. Tried splicing the healambrosia and strange seed's phytochem into a brand new ambrosia seed, and didn't work either.

Difference between expected and actual behavior

Expected to be able to splice the rezadone, peridaxon and thymol to the ambrosia. Couldn't. The splicing wouldn't happen. Not even a change in potency from the source seed's phytochemistry.

Steps to reproduce

Splice ambrosia vulgaris, rocknut and kudzu's phytochemistry into ambrosia deus. Raise potency and try to splice a strange seed.

Server revision

Game: d59886e4bd0382cad24b75502884024bec978b79 Patches: 289574d4b9f227a658b39a47a7f10119d33c9a2a

adacovsk commented 2 years ago

@Eneocho this can't be solved with how plant chems work currently. There is a max volume each plant can hold, and once it reaches that, it will not splice more chemicals. There's no easy fix without redoing how chems work

Eneocho commented 2 years ago

Clearly the solution is to increase the amount of chemicals a plant can hold for the turbogiga 500u blunts of cocaine overdose.

Eneocho commented 2 years ago

@adacovsk The issue is that the problem ONLY happens with ambrosia deus, it doesn't happen on grass, ambrosia vulgaris, potatoes, etc, so I don't think it's a plant-chem system issue.

Eneocho commented 2 years ago

Also of note, you can still splice potency if you use a standard grass potency disk.

adacovsk commented 2 years ago

weird