vgstation-coders / vgstation13

Butts

GNU General Public License v3.0

260 stars 540 forks source link

Shuttle not gibbing people inside of stuffz #28954

Open D3athrow-Issues opened 3 years ago

D3athrow-Issues commented 3 years ago

(WEB REPORT BY: kirbythewizard101 REMOTE: 206.221.180.138:7777)

Revision

a0fc71b279ceb41c8c5387b08e60d2cc4f15bef8

Description

If you're in a locker, cage, inflatable shelter, or anything else that you can get into, the shuttle landing on you wont gib you and will only destroy the item you are in.

Steps to Reproduce

Put yourself into a locker in space, and call the emergancy shuttle, mining shuttle, sci shuttle, or any shuttle and see that you survive

What you Expected

For it to kill me

What Actually Happened

I survived

ghost commented 3 years ago

It seems shuttle_act() is only called on /obj/structure/closet/shuttle_act() (lockers?) and nowhere in cages and inflatable shelters, and shuttle_act() is called on the colliding mob directly, negating the parent object they're inside. When called on any living mob (mob/living) directly, it checks if theyre invulnerable and if not, adminwarns and then gibs them. That might be the root of the issue, I'll take a look at it

west3436 commented 3 years ago

this is one of my favorite features pls do not remove

Exxion commented 3 years ago

Haven't we fixed this like three times

ghost commented 3 years ago

Issue seems to be just not calling shuttle_act() on living mobs at all for some reason, if that helps. Yet somehow, forcemoving them out of the structures works just fine.