vgstation-coders / vgstation13

Butts
GNU Affero General Public License v3.0
265 stars 546 forks source link

Phytochemistry Problems MK II #28995

Open Eneocho opened 3 years ago

Eneocho commented 3 years ago

Description of issue

Some chems are impossible to directly splice into a plant. Other times, you can't add any chems to a plant, regardless of the datadisk. There's a roundabout way to splice them, by using a second plant as a buffer, splicing all the chems into it and purging that into your target plant, but it is cumbersome and weird.

If, for example, I wanted to make Healing Ambrosia Deus, I'd splice Vulgaris, for tannic acid and opium, Rocknuts for iron and Kudzu for Allicin into an Ambrosia Deus seed. But when checking the final product, the seed doesn't have said Allicin. Sometimes also lacking the Iron.

If I take that spliced deus seed and try to splice the Allicin and Iron again, it fails. It does the whole bioballistic thing but doesn't splice anything.

Difference between expected and actual behavior

Expected to be able to splice chems correctly into a plant. Couldn't and had to use a roundabout method to do it.

Steps to reproduce

Acquire Kudzu, Rocknut, Ambrosia Vulgaris and Ambrosia Deus seeds. Extract the Phytochemistry from Rocknuts, Vulgaris and Kudzu. Splice Rocknut into Deus. Splice Vulgaris into Deus. Splice Kudzu into Deus. End up with a plant lacking Kudzu's Allicin and/or Rocknut's Iron.

Length of time in which bug has been known to occur

Apparently long enough for many botany players to notice and know about.

[bugfix]

Killette3 commented 3 years ago

What was the end potency?

Eneocho commented 3 years ago

About 140. And before the "Maybe the plant is full and it need space to have new chems" point, I also thought that at first. It ain't that, chief.

Killette2 commented 3 years ago

This makes no sense to me either then, ignore the alternating github accounts. I'll try to troubleshoot this on my own time but will admit I have not tried to make a healing plant outside of that one round with you in over a year so my experiences are nowhere as informed as yours

Eneocho commented 3 years ago

I found an important thing. If you splice Allicin/Iron into ANY plant spliced with deus+vulgaris, it fails. It works if you splice the Allicin and the iron into an empty seed THEN splice the deus+vulgaris into it.

The process I have is: Acquire Rocknut, Kudzu, Vulgaris and Deus seeds. Take their Phytochemistry. Take a grass seed. Splice Kudzu first. Splice Rocknut second. Splice Vulgaris and Deus in any order. Extract the Phytochemistry from the spliced grass. Purge into a new (seed machine) Deus seed. You now have all the chems spliced in the seed.

If you don't do this very cumbersome process, the seed ends up as if you only spliced Vulgaris into Deus, and nothing else.

Killette1 soon?

Killette3 commented 3 years ago

I also had this problem. Tried splicing a kudzu phytochemistry into a vulgaris seed. The potency did not change, the end chemicals did not change. It's as if it ignored the kudzu potency splicing.

Eneocho commented 3 years ago

I also had this problem. Tried splicing a kudzu phytochemistry into a vulgaris seed. The potency did not change, the end chemicals did not change. It's as if it ignored the kudzu potency splicing.

Precisely the bug I am reporting. If you do the process I described, you DO get the result. It is a very weird bug.

adacovsk commented 2 years ago

@Killette2 @Killette3 I'll have to redo the entire plant chems system to fix it

Eneocho commented 2 years ago

@Killette2 @Killette3 I'll have to redo the entire plant chems system to fix it

@adacovsk Stated on the other similar issue, but the problem only happens with ambrosia deus, not any other plant (you can mass splice to watermelons without issue, for example). Saul_Myers even developed a proven method to force the splice to go through anyway and it is now on the wiki.