vgstation-coders / vgstation13

Butts

GNU Affero General Public License v3.0

265 stars 546 forks source link

Trade Outfitter wires can't be pulsed #29420

Closed D3athrow-Issues closed 9 months ago

D3athrow-Issues commented 3 years ago

(WEB REPORT BY: tinysaturn REMOTE: 206.221.180.138:7777)

Revision

8537952f7c19eb85e7ff2dc37d3ca3326b6c3112

Description

Trade Outfitter's wires can't be pulsed with a multitool, only cut

Steps to Reproduce

unscrew panel, try to pulse

What you Expected

it to work

What Actually Happened

pulsing wires does nothing

Kurfursten commented 3 years ago

Intended behavior is for neither cutting or pulsing to work, as per the description

Eneocho commented 3 years ago

Feature. Though it should have the hacking part removed or revamped. An idea would be to have it be hackable for access or shock, but it cant spit items, pulsing/cutting the item throwing cable giving you a "Shoal reinforced tradervends are impervious to free dispensal, nice try, now go get those credits."

Kurfursten commented 3 years ago

I looked into this more. It's due to the implementation of CutWireIndex() and when it calls UpdateCut() (after changing the indexed wire to cut).

Basically although you can cut the wires, it won't do anything if you cut wires on an unhackable machine. In truth, you shouldn't even be able to unscrew the maintenance panel because none of the unhackable machines even have a panelopen sprite state.

west3436 commented 9 months ago

Likely not even applicable anymore with the new trader vend