vgstation-coders / vgstation13

Butts
GNU Affero General Public License v3.0
265 stars 546 forks source link

Remove Blog Conglomerate #29556

Open D3athrow-Issues opened 3 years ago

D3athrow-Issues commented 3 years ago

(WEB REPORT BY: sugarbone REMOTE: 206.221.180.138:7777)

Revision

88ffb70118d9dfc7d757e0d0ead628f9a8955a45

Description

4 Blob Conglomerate rounds in a row

Steps to Reproduce

  1. Join in
  2. Get a blob round
  3. Wait till next round
  4. Get 3 more blob rounds in a row

    What you Expected

    Normal rounds with even antag distribution

    What Actually Happened

    4 Bl*b rounds in a row

ShiftyRail commented 3 years ago

That's because Tuesday is blob day.

Zth-- commented 3 years ago

https://github.com/vgstation-coders/vgstation13/blob/55c6e6715a7f109c4ed840d52266b54f748cc408/code/datums/gamemode/dynamic/dynamic_rulesets_roundstart.dm#L515

This might be a bit too much. Ignore the comment, this means that pop bigger than 12 will generate 2 blobs. Bigger than 37 will generate 3 blobs and so on.

Exxion commented 3 years ago

No, round() with only one argument is a floor function. http://www.byond.com/docs/ref/#/proc/round

Zth-- commented 3 years ago

Oh, damn