vgstation-coders / vgstation13

Butts
GNU Affero General Public License v3.0
265 stars 546 forks source link

Splicing morphology doesn't change the fruit Icon on the spliced crop, so you end up with bananas that look like cherries. #31307

Open Eneocho opened 2 years ago

Eneocho commented 2 years ago

Description of issue

If you splice morphology from one plant to another, you can make a plant that produces two different crops on harvest (kinda like grafting a branch from an apple tree to a pear tree). The problem is that the new crops share the original crop's icon, so you have bananas that look like cherries alongside regular cherries (from the same plant). You can eat the banana-cherry and it behaves like a normal banana. You can use it in banana recipes, it even leaves a peel when eaten and all, but until then it looks like a cherry.

Difference between expected and actual behavior

Expected morphology splicing to also splice the icons so a watermelon into tomato morphology splice produced both watermelons that look like watermelons and tomatoes that look like tomatoes. Got tomatoes that look like tomatoes as intended, but also got watermelons that look like tomatoes.

Steps to reproduce

Grab two (2) different seeds. Extract morphology from one of them. SPLICE (not purge) the morphology to the other seed. Plant and wait for it to bear fruit. Right click on the tile to see that you now have 2 different crops from the same plant, but they both look like the "receiving" plant.

Length of time in which bug has been known to occur

Probably since morphology splicing became a thing. [oversight][featurerequest][sprites]

Eneocho commented 2 years ago

Same issue as #25268.