vgstation-coders / vgstation13

Butts
GNU Affero General Public License v3.0
265 stars 544 forks source link

Found the problem with ramen lads #32089

Open Kharkov72 opened 2 years ago

Kharkov72 commented 2 years ago

/datum/chemical_reaction/hot_ramen name = "Hot Ramen" id = HOT_RAMEN result = HOT_RAMEN required_reagents = list(WATER = 1, DRY_RAMEN = 3) result_amount = 3 required_temp = 100+T0C

As you can see it has required_temp but the reagent itself is hot meaning eventually unless you manage to react all of it at the exact same time it will stop reacting should we just remove this stupid temp requirement or is there a better way

Description of issue

Difference between expected and actual behavior

Steps to reproduce

Specific information for locating

Length of time in which bug has been known to occur

Server revision

Eneocho commented 2 years ago

Wasn't it made like this so the heat from the calcium oxide on the ramencup heated up the dry ramen by reacting with water, thus heating the cup's reagents, thus reacting the ramen with the water?

adacovsk commented 2 years ago

it's easier to heat smaller amounts, so you can lower the temperature for reaction or decrease the units i.e. 1->0.1 3->0.3 for a reaction (I think)

Cartlord commented 2 years ago

Are we sure that the issue isn't just that the added water reduces the heat of the mixture, and by the time you've added enough water to convert all the dry ramen to hot ramen, the mixture has cooled close enough to room-temp (from the water, which i presume is spawned room-temp by sinks) that the leftover heat isn't enough to convert the dry ramen to hot ramen?

Eneocho commented 2 years ago

Obviously the solution here is to make the calcium oxide reaction make more heat: https://www.quora.com/How-much-heat-will-be-released-from-the-reaction-of-calcium-oxide-and-water Some of the math is wonky, but it works enough.

Eneocho commented 2 years ago

We don't really need realistic numbers (though it would be nice), just bump the heat enough so ramen reacts properly.

Cartlord commented 2 years ago

...Wouldn't it be easier to lower the temp requirement for the ramen reaction?

Exxion commented 2 years ago

It would be exactly equally as easy

Cartlord commented 2 years ago

I think that, in that case, it might be easier to lower the ramen's heat or water requirement, because raising the heat produced by the potassium hydroxide reaction might affect something else as well.

Eneocho commented 2 years ago

Or just add more calcium oxide to each ramen packet.

Cartlord commented 2 years ago

I don't know enough about the reaction to know if that will or won't cause problems, which is compounded since calcium oxide isn't on the Guide to Chem.

Eneocho commented 2 years ago

I don't know enough about the reaction to know if that will or won't cause problems, which is compounded since calcium oxide isn't on the Guide to Chem.

It isn't because it's not a chemical you can make, since there is no calcium in the code, you can only find it on purchased ramen packs (chef-made ramen doesn't have calcium oxide). All "calcium" recipes currently use milk instead (degen calcium, mostly). I am working on a PR to add calcium as a chem as well as various assorted chemicals that require calcium to make, but that will take some time.