search

vgstation-coders / vgstation13

Butts
GNU Affero General Public License v3.0
265 stars 544 forks source link

Upgrading the Seed Extractor doesn't actually do anything. #32240

Open Cartlord opened 2 years ago

Cartlord commented 2 years ago

Description of issue

If you upgrade the seed extractor, it won't make any more seeds, despiet what the wiki says.

Difference between expected and actual behavior

Expected more seeds, got the same number of seeds.

Steps to reproduce

-Extract seed -Upgrade -Extract seeds again -Same amount

Server revision

Game: 6f20e1f4bec7ded96610f85d587083c940e075e0 Patches: 609a806a066b5859e732b12938343551efcc77f7 Current Infomational Settings: Protect Authority Roles From Tratior: 1

[bugfix]

Eneocho commented 2 years ago

It actually increases the chance to get more seeds. Seen how you some times get 1 or 2 seeds but other times you get like 5? Upgrading increases the odds of the latter happening.

Cartlord commented 2 years ago

Odd. The wiki says only one of the upgradable parts does that, and the other increases minimum seeds.

Kurfursten commented 2 years ago

The seed extractor does work properly, and it sets its values for min_seeds and max_seeds right

However the seedify() proc is very badly written and it looks like it's preventing the vars from being used right (around L1783 of unsorted.dm)