search

vgstation-coders / vgstation13

Butts
GNU Affero General Public License v3.0
266 stars 546 forks source link

Flashbangs sometimes pierce HoS hat protection #33055

Closed BomberBro closed 2 years ago

BomberBro commented 2 years ago

I've never seen this bug before, but I was stunned for about 5-10 seconds after throwing a flashbang 4-5 tiles away. Wearing the sunglasses and the standard hat. No flash or anything, but I was completely deafened. bangerbros Even checked to make sure I didn't get it thrown back at me, no clue how it happened.

nervere commented 2 years ago

I was able to replicate this locally, but subsequent flashbangs didn't trigger the stun again. I'm dumb, that's because I was deaf! The HoS hat doesn't protect you because flashbangs check for NoiseDampening(), which is a proc that returns true for helmets. The HoS hat's path is /obj/item/clothing/head/HoS, so I'm not sure if it ever protected against flashbangs? I don't know if this is actually a bug unless I'm misunderstanding which hat you're talking about.

BomberBro commented 2 years ago

I was under the impression the HoS hat had flashbang protection, I'm gonna ask couple secmains if this was the case in the past or if I'm just retarded and I'll close it if it's the latter.

Theophrastus1 commented 2 years ago

I was under the impression the HoS hat had flashbang protection, I'm gonna ask couple secmains if this was the case in the past or if I'm just retarded and I'll close it if it's the latter.

fairly certain the only one that ever did was dermal patch. the Warden hat has flashbang protection to my knowledge but i am not as certain now

nervere commented 2 years ago

@BomberBro I found the issue. Believe it or not, Cult 4 is partly to blame.

The issue is twofold. Firstly, this PR changed a lot of security gear to not be helmets two years ago (but it didn't matter because if the clothing covered ears it'd protect against flashbangs). See this commit: https://github.com/vgstation-coders/vgstation13/commit/263c221db771e4516d81b6554b597c7dabf23c0d

Secondly, and more importantly, Cult 4 changed how flashbang protection works, and it didn't account for what it'd break: https://github.com/vgstation-coders/vgstation13/pull/30672

I'll switch the tags on this issue because you're right that they used to have flashbang protection and removal was never intended.

BomberBro commented 2 years ago

>diety gives cult hoods flashbang immunity >removes it from the HoS and presumably Warden gear can't make this shit up