vgstation-coders / vgstation13

Butts
GNU Affero General Public License v3.0
266 stars 545 forks source link

Fish Vanishing #33324

Closed D3athrow-Issues closed 2 years ago

D3athrow-Issues commented 2 years ago

(WEB REPORT BY: mogilniyvosk REMOTE: 206.221.180.138:7777)

Revision

a3aaae8dcc80069a49f500dce015fd06536e5909

Description

Fish are vanishing when harvested from the aquarium. Net is used, but the fish do not appear either on floor or inventory.

Steps to Reproduce

What you Expected

Fish to appear when harvested using fish net.

What Actually Happened

Fish are removed from aquarium count, but fail to appear outside of said aquarium.

adacovsk commented 2 years ago

coincidence? #33068

Well, something definitely changed, I can't harvest fish either

adacovsk commented 2 years ago

proc name: harvest fish (/obj/machinery/fishtank/proc/harvest_fish)
usr: Dylan Leslie (adacovsk) (/mob/living/carbon/human)
usr.loc: The floor (273, 252, 1) (/turf/simulated/floor)
src: the fish tank (/obj/machinery/fishtank/tank/full)
src.loc: the floor (272,251,1) (/turf/simulated/floor)
call stack:
the fish tank (/obj/machinery/fishtank/tank/full): harvest fish(Dylan Leslie (/mob/living/carbon/human))
the fish tank (/obj/machinery/fishtank/tank/full): attackby(the fish net (/obj/item/weapon/fishtools/fish_net), Dylan Leslie (/mob/living/carbon/human), "icon-x=23;icon-y=19;left=1;but...")
Dylan Leslie (/mob/living/carbon/human): ClickOn(the fish tank (/obj/machinery/fishtank/tank/full), "icon-x=23;icon-y=19;left=1;but...")
the fish tank (/obj/machinery/fishtank/tank/full): Click(the floor (272,251,1) (/turf/simulated/floor), "mapwindow.map", "icon-x=23;icon-y=19;left=1;but...")
Adacovsk (/client): Click(the fish tank (/obj/machinery/fishtank/tank/full), the floor (272,251,1) (/turf/simulated/floor), "mapwindow.map", "icon-x=23;icon-y=19;left=1;but...")

Also lobsters, clownfish, and shrimp might have wrong type