vgstation-coders / vgstation13

Butts
GNU Affero General Public License v3.0
265 stars 546 forks source link

Core R&D Console crashes the BYOND client. #33813

Open D3athrow-Issues opened 1 year ago

D3athrow-Issues commented 1 year ago

(WEB REPORT BY: ezudiko REMOTE: 206.221.180.138:7777)

Revision

04be7d7ea701fb590d755623543e7ebba433a336

Description

Clicking on the Core R&D console causes the client to lock-up and freeze.

Steps to Reproduce

Print a weapon circuit board.

What you Expected

To print.

What Actually Happened

BYOND shat the bed.

This is only hearsay from my current round based on ahelps between myself and the scientist. This may need further testing for diagnosis. Nuking the Core R&D console and spawning a new one resolves the issue, so it appears related to research levels and then subsequently printing therefrom.

smorbit commented 1 year ago

Also to further clarify, after printing the weapon circuit board, multiple people including myself as an admin, the HoS, and the RD would then have our clients lock-up once we click on the R&D console from that point onwards.

Exxion commented 1 year ago

So this started only after clicking the button to print a weapon circuit board?

smorbit commented 1 year ago

As per my understanding yes, as that's the steps I asked the RD to take to reproduce the issue. From then on, clicking on the console as a ghost or as a player would lockup the client. I know it's not the best reproduce steps, but I hope that gives somewhere to start debugging it.

Edit: Deleting the console (all linked research levels) "fixes" the problem, where I then asked the RD to tech up again to where he got to weapons boards, printed one, issue occurs again.

Exxion commented 1 year ago

I experienced the crash on the live server in that round, but can't seem to reproduce it locally. What exact circuit design did he print?

smorbit commented 1 year ago

I asked the player who mentioned it was one of the two weapon ones, though he's unsure which one. He believes it was the Gygax, and he printed two successfully, then it "went to hell" in his words.

Exxion commented 1 year ago

Something clearly fucked up, but I can't reproduce it locally, and don't even know what could cause this crash. I'm going to just say "random computer bullshit" unless it happens again